loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 70 forks source link

Stone wool not acquired automatically in some situations #14

Open macgregor opened 5 years ago

macgregor commented 5 years ago

Issue by txrangersxx Tuesday Mar 19, 2019 at 16:40 GMT _Originally opened as https://github.com/soolar/sl_ascend/issues/103_


Get steel wool either by adventuring or using wish

macgregor commented 5 years ago

Comment by taltamir Sunday Mar 24, 2019 at 04:27 GMT


Doing it in standard too. It worked about a week ago I think. But last run it errored out saying I am not stone faced when it expected to be. But I had no stone wool in inventory. Maybe it tried to use stone wool without first checking to see if I have any? I will try to get a clearer diagnosis of what is going on here

macgregor commented 5 years ago

Comment by taltamir Tuesday Mar 26, 2019 at 06:28 GMT


Yea, it happened again on another standard run. It doesn't even try to acquire stone wool, it just decides to open the temple and then errors out with being not stone faced

[454] Summoning Chamber
Encounter: Lord Spookyraven
Round 0: taltamir loses initiative!

battle against lord spookyraven goes here and was manually cut for being too long and irrelevant.

You acquire an item: Eye of Ed
You acquire an item: Lord Spookyraven's ear trumpet
After Battle: Statchell gives you a big X. Survey says... X.
You acquire an item: X
After Battle: You gain 38 Muscleboundness
After Battle: You gain 129 Enchantedness
After Battle: You gain 32 Smarm

Post Adventure done, beep.
Turn(454): Starting with 16 left at Level: 13
Still flyering: 5736
Encounter: -26.0 Exp Bonus: 19.55625
Meat Drop: 220.0 Item Drop: 259.71651780264983
HP: 255/255, MP: 1489/1654
Tummy: 15/15 Liver: 9/20 Spleen: 1/15
ML: 47 control: 11
Delay between adventures... beep boop... 
Countdown: 1 second...
Waiting completed.
Holding Kramco Sausage-o-Matic™...
Equipment changed.
Must get a snake nose.
We are not Stone-Faced. Please get a stone wool and run me again.
Loading character status...
Installing default certificate validation...
Sending login request...
Synchronizing moon data...
Requests complete.
macgregor commented 5 years ago

Comment by faceboogle Sunday Mar 31, 2019 at 06:44 GMT


I get this too. Just after beating Greg Dagreasy (lord spook raven replacement) in a HC DG run:

Must get a snake nose. We are not Stone-Faced. Please get a stone wool and run me again.

macgregor commented 5 years ago

Comment by txrangersxx Sunday Mar 31, 2019 at 19:47 GMT


Im HC Std it went and got the stone wool

macgregor commented 5 years ago

Comment by Saklad5 Tuesday Apr 09, 2019 at 21:49 GMT


This still happens, due to https://github.com/soolar/sl_ascend/pull/150 not affecting the check at https://github.com/soolar/sl_ascend/blob/a831673f6b1ab0ef904fafa939d63cf144700321/RELEASE/scripts/sl_ascend.ash#L6225-L6236. I’m a bit too busy to investigate beyond that right now.

macgregor commented 5 years ago

Comment by MatthewDarling Saturday Apr 13, 2019 at 00:05 GMT


How many Stone Wool are needed to complete the quest? When I ran out of wishes and hit this, I manually collected a single Stone Wool drop from a regular sheep. And then sl_ascend completed the rest of the quest without complaint.

It didn't seem to take very long - maybe like 5 adventures? Hardly seems worth aborting the script over, and probably not an optimal wish.

macgregor commented 5 years ago

Comment by medchem Thursday Apr 18, 2019 at 05:25 GMT


@MatthewDarling I often farm two before re-running the script, just for safety.

macgregor commented 5 years ago

Comment by jaspercb Monday Apr 29, 2019 at 18:44 GMT


If you have genie bottle: set sl_useWishes=true will start using Baa'baa'bu'ran for stone wool. Otherwise, uh, TODO.

taltamir commented 4 years ago

To sum up this issue. We only have 1 method of getting stone wool at the moment, which is to use a fortune cookie and then get a semirare that drops stone wool. If this fails to work for some reason (such as being a path that does not allow eating fortune cookies. or needing your semirare for something else, or being full already, or what not) then it will get stuck and ask the player to manually acquire stone wool. Thus we should program a fallback method of just adventuring in the pyramid and sniuffing stone sheep for the necessary stone wool

Malibu-Stacey commented 4 years ago

To sum up this issue. We only have 1 method of getting stone wool at the moment, which is to use a fortune cookie and then get a semirare that drops stone wool. If this fails to work for some reason (such as being a path that does not allow eating fortune cookies. or needing your semirare for something else, or being full already, or what not) then it will get stuck and ask the player to manually acquire stone wool. Thus we should program a fallback method of just adventuring in the pyramid and sniuffing stone sheep for the necessary stone wool

It works fine in G-Lover post #500 changes (G-Lover also can't get a semirare counter as Fortune Cookies and Lucky Lindy's don't have G's and can't even use Stone Wool if acquired from the baa-relief sheep or elsewhere for the same reason either) but it's especially terrible in G-Lover as -combat sources are almost non-existent. image

in L11_unlockHiddenCity() I think all that needs done for this is the line if (auto_my_path() != "G-Lover" && !in_tcrs()) { needs to also exclude Vampyre.

taltamir commented 4 years ago

I do believe you are correct. should be a simple fix then.

edit: wait. #500 still says we do not farm stone wool. And it does not address the possibility of this happening in HC standard. I think what we need is to add the possibility of farming stone wool in general instead of the abort if we do not have the effect.