loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 70 forks source link

Disambiguate AoSoL's Punt skill #1428

Closed ziz closed 7 months ago

ziz commented 7 months ago

Description

AoSoL's Punt is 28021, which autoscend supports. WereProfessor added a Punt skill number 7510 (support was added in Mafia r27841), so now mafia throws multiple skill match warnings.

Adding [7510]Punt (duplicating the [28021]Punt use, more or less) to auto_combat_util.ash would make sense if autoscend is expected to eventually handle WereProfessor, but that's more than just a trivial warning-removal fix.

How Has This Been Tested?

Before patch, importing autoscend.ash gives

Multiple matches for "Punt"; using "[28021]Punt". (auto_combat_util.ash, line 641, char 28 to char 32) Clarify by using one of:
$skill[[7510]Punt]
$skill[[28021]Punt]
Multiple matches for "Punt"; using "[28021]Punt". (auto_combat_util.ash, line 641, char 64 to char 68) Clarify by using one of:
$skill[[7510]Punt]
$skill[[28021]Punt]
Multiple matches for "Punt"; using "[28021]Punt". (auto_combat_util.ash, line 643, char 28 to char 32) Clarify by using one of:
$skill[[7510]Punt]
$skill[[28021]Punt]
Multiple matches for "Punt"; using "[28021]Punt". (avatar_of_shadows_over_loathing.ash, line 72, char 28 to char 32) Clarify by using one of:
$skill[[7510]Punt]
$skill[[28021]Punt]
Multiple matches for "Punt"; using "[28021]Punt". (avatar_of_shadows_over_loathing.ash, line 220, char 26 to char 30) Clarify by using one of:
$skill[[7510]Punt]
$skill[[28021]Punt]

After patch, these warnings are gone.

Checklist: