Bees Hate You and G-Lover Fixes

[Donald-Lafleur]

Description

This fixes an issue I had in all prior BHY autoscend runs where 50+ turns would get spent losing to Ed. Every time 2 B's we're being worn into the 5 round combat which guaranteed 100% damage by the start of round 5. The other issues were almost all places where the maximizer wanted to fold the January's Garbage Tote. The wad of used tape kept getting chosen by the maximizer for MP and +10% to all stats.

It also fixes the G-Lover path problems described in issue #1419

How Has This Been Tested?

I did a couple BHY runs in a row and was able to confirm that major issues I had in earlier runs are absent from the most recent ones. In particular the Ed issue and the maximizer crashes haven't happened.

I've done most of one G-Lover run without any issues. I know the fix for the Disco Nap infinite loop works because I got the infinite loop myself then changed that line to fix it. I looked through my logs and found that when autoscend wished for the first fight on the second day I already had pocket wishes from BoFa, so that seems fixed as well.

Checklist:

• [X] My code follows the style guidelines of this project.
• [X] I have performed a self-review of my own code.
• [X] I have commented my code, particularly in hard-to-understand areas.
• [X] I have based my pull request against the main branch or have a good reason not to.

[Donald-Lafleur]

Fixed my fork and rebased. Maybe time to go read the entire git manual.

[Donald-Lafleur]

I'm going to leave the PR open, but give me a few days before reviewing this.

I finally realized I could checkout my own working branch in mafia instead of manually editing an existing autoscend install. I'm going to do another run or two with this branch from the repo itself now that I have a proper workflow.

[Donald-Lafleur]

I have decided to act on Hippoking's suggestion by venturing to split this into smaller more manageable units with better cohesion. I sat down and read the friendly Git manual enough to learn how to do that without just rewriting it all from scratch, I think.

I think this series of commits can be logically split up into ~10-15 independent changes, so that's what I'm going to try and turn it into. The rough plan is to submit PRs for each of the following one after another:

• Disco Nap infinite recovery loop fix
• G-Lover specific combat handling
• Adding auto_is_valid checks to a ton of places that impact G-Lover as well as adding to the list of G-Lover G exceptions
• Improve IotM support where "using" isn't actually required (tbd whether this will be 1 or 4 PRs)
• Implement magical bookcase support to use librams and tomes in G-Lover
• Fix auto_beatenUpCount and Locations tracking
• Reorder trainset and deck initialization
• Fix the BHY maximizer crashes from garbage tote
• Add designer sweatpants to list of discount sources
• Improve checking for available better or equivalent items in the pull logic