HippoKingKoL commented 3 months ago

Description

This includes April's IOTM, the Apriling Band. It does four things with it.

Summons the April Tuba and April Sax
Generates lucky adventures using the April sax.
Forces noncombats using the April Tuba.
Uses the +combat and -combat intrinsic functions.

Additionally, this PR adds a priority to using the Spring Shoes, because they generate + and - combat potions, and also MP.

It adds a monkey paw wish usage to grab the Drum Machine if necessary.

Finally, this contains various changes/fixes to Kingdom of Exploathing, which was a bit broken.

Fixes # (issue)

How Has This Been Tested?

Standard HC ascension for the Apriling Band and Spring Shoes stuff. Half a KoE HC ascension for the changes there. This will be fully tested before merging.

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have based my pull request against the main branch or have a good reason not to.

HippoKingKoL commented 3 months ago

I'm happy with this as far as Apriling Band goes, which is the main part of it.

The KoE stuff is still slightly dodgy. I've got rid of the showstoppers, but the invader fight is still unreliable. It's going to take more understanding of how the fight preparation code (which I might get some time?) to work that out. It's definitely an improvement, at least.

I think this can be reviewed and merged now.

dsimich commented 3 months ago

When does it summon the instruments? I see the function to summon them but I don't see it called anywhere.

HippoKingKoL commented 3 months ago

When does it summon the instruments? I see the function to summon them but I don't see it called anywhere.

Good catch. It got wiped out in the merge somehow. Redone now.

https://github.com/loathers/autoscend/pull/1440/commits/fe4aae108c88e5d601df6d84237916f5112eba47

dsimich commented 3 months ago

Other interrupts that I had were not being able to cast The Ode to Booze because it wasn't purchasing the Antique Accordion from Cosmic Ray's Bazaar (had a stolen accordion but as SC can't use that) and I didn't get enough White Pixels in run. Not sure if the antique accordion is within the scope of this PR though and I think the White Pixel issue can just be manually bypassed if encountered

loathers / autoscend

Apriling band implementation, and smoe updates to Kingdom of Exploathing. #1440

Description

How Has This Been Tested?

Checklist: