cpenny86
commented
2 months ago Hmm, true, it's ambiguous. When I asked the same question I just got the PRs Welcome sticker in return, so... I made one.
Upon reflection, the behaviour is "we didn't initialize the briefcase, so we don't know any combos that the user may already have found, but we're just going to use it anyway." So perhaps "do not" instead of "can not/cannot" would be the better choice, actually.
On Fri, May 10, 2024, 2:43 p.m. dsimich @.***> wrote:
@.**** commented on this pull request.
In RELEASE/scripts/autoscend/iotms/mr2017.ash https://github.com/loathers/autoscend/pull/1450#discussion_r1597095479:
@@ -819,7 +819,7 @@ boolean kgb_getMartini(string page, boolean dontCare) { if(!dontCare) {
- auto_log_info("We did not initialize the briefcase this ascension, we can not care", "red");
- auto_log_info("We did not initialize the briefcase this ascension, we cannot care", "red");
I don't have a KGB so I don't have any horse in this game, but is it that we can't care or do we have the luxury of not caring? If it's the latter, then technically it was right because we set dontCare to true
— Reply to this email directly, view it on GitHub https://github.com/loathers/autoscend/pull/1450#pullrequestreview-2050652888, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR3TK346GM5H5M6GZAY2ALZBUILTAVCNFSM6AAAAABHRBVRSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJQGY2TEOBYHA . You are receiving this because you authored the thread.Message ID: @.***>
Description
Grammatical fix, lines 822 and 912 (can not -> cannot). Does not address any open issues; just something that always bugs me when I see it flow through on the CLI.
-SadOatcakes :)
If it addresses a particular issue, please put the issue numbers below (see also Closing Issues Using Keywords).
Fixes # (issue)
How Has This Been Tested?
I did not test this as it shouldn't change anything about how the script runs; it's a superficial edit to a CLI message.
Checklist: