loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 67 forks source link

Infinite Loop during Spookyraven Quest #153

Closed c0mp13371331337 closed 4 years ago

c0mp13371331337 commented 4 years ago

Context

Expected/Desired Behavior

Would expect it to complete Spoopyraven questline without going into an infinite loop.

Current Behavior

Goes into an infinite loop at certain points during the Spoopyraven questline. Had to finish getting the items for Lady Spookyraven on the 2nd floor (Bathroom and Bedroom), then visit the Ballroom once, and the script was able to take over from there.

Failure Information (for bugs)

There is no stack trace as the script never aborts, it just goes into an infinite loop.

Failure Logs

[447] The Shore, Inc. Travel Agency Took choice 793/2: Mysticality Vacation choice.php?whichchoice=793&option=2&pwd You lose 3 Adventures You spent 500 Meat You acquire an item: copy of a jerk adventurer's father's diary

diary.php?textversion=1

Postadventure skipped by standard adventure handler. diary.php?textversion=1 Turn(449): Starting with 75 left at Level: 11 Encounter: 20.0 Exp Bonus: 22.22916666666667 Meat Drop: 0.0 Item Drop: 65.0 HP: 312/312, MP: 405/405 Tummy: 4/5 Liver: 4/4 Spleen: 35/35 ML: 71 control: 11 Ka Coins: 22 Lashes used: 15 Delay between adventures... beep boop... Searching for the basement of Spookyraven Starting preadventure script... Maximizing: 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,6mp regen,0.25spell damage,1.75spell damage percent,10exp,5Mysticality experience percent Burning 26 MP...

cast 1 Blessing of Serqet You acquire an effect: Blessing of Serqet (10)

cast 2 Wisdom of Thoth You acquire an effect: Wisdom of Thoth (20)

Pre Adventure at The Haunted Ballroom done, beep. Starting Ed Battle at The Haunted Ballroom If 'That Area is not available', mafia isn't recognizing it without a visit to manor2, not sure why. Turn(449): Starting with 75 left at Level: 11 Encounter: 20.0 Exp Bonus: 23.87916666666667 Meat Drop: 0.0 Item Drop: 65.0 HP: 312/312, MP: 380/405 Tummy: 4/5 Liver: 4/4 Spleen: 35/35 ML: 71 control: 11 Ka Coins: 22 Lashes used: 15 Delay between adventures... beep boop... Searching for the basement of Spookyraven Starting preadventure script... Maximizing: 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,6mp regen,0.25spell damage,1.75spell damage percent,10exp,5Mysticality experience percent Pre Adventure at The Haunted Ballroom done, beep. Starting Ed Battle at The Haunted Ballroom If 'That Area is not available', mafia isn't recognizing it without a visit to manor2, not sure why. Turn(449): Starting with 75 left at Level: 11 Encounter: 20.0 Exp Bonus: 23.87916666666667 Meat Drop: 0.0 Item Drop: 65.0 HP: 312/312, MP: 380/405 Tummy: 4/5 Liver: 4/4 Spleen: 35/35 ML: 71 control: 11 Ka Coins: 22 Lashes used: 15 Delay between adventures... beep boop... Searching for the basement of Spookyraven Starting preadventure script... Maximizing: 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,6mp regen,0.25spell damage,1.75spell damage percent,10exp,5Mysticality experience percent Pre Adventure at The Haunted Ballroom done, beep. Starting Ed Battle at The Haunted Ballroom If 'That Area is not available', mafia isn't recognizing it without a visit to manor2, not sure why.

https://pastebin.com/frC4gQ8g

Malibu-Stacey commented 4 years ago

Your log is weird. It just gives up during the Haunted Bedroom and goes off to the Haunted Gallery without fighting the cosmetic wraith to get the powder puff. In over 40 Ed runs on my test account I've never seen this happen.

However I suspect this is strongly linked to #30 if not entirely caused by it as the log shows you were still in the One Mahogany Nightstand non-combat when it decided to go to The Haunted Gallery (from line 7633 in the log onwards). I've seen this cause all sorts of issues during runs (e.g. if you run out of MP & it can't buy restores because its stuck in the post-combat choice it then adventures again & gets killed because it can't cast anything).

c0mp13371331337 commented 4 years ago

That would make sense. This occurred during my first Ed run in quite some time (was taking a break to farm KoE books). And it happened to occur on the first of four multis. After this one instance, my other three multis made it past this point no issues, so it's definitely a pretty intermittent issue, and probably caused by a pretty obscure trigger, as you mentioned.

Malibu-Stacey commented 4 years ago

Going to assume this is also fixed by the fix for #181 as it's kind of impossible to reproduce.

Malibu-Stacey commented 4 years ago

Having looked at the code, I think I've fixed this on my exploathing branch. It appears to be caused by getting to the level 11 quest and not having danced with lady spookyraven so the ballroom is accessible (or at least found all her dancing things). Currently all we check for is that the 2nd floor is open, the macguffin quest is at the right point and the ballroom NC (We'll all Be Flat) hasn't been triggered yet. Was planning on putting the PR for that code up today as I've finished my last test run & it all looks good.

Malibu-Stacey commented 4 years ago

Should be fixed since #207 was merged to beta.