briefcase infinite loop during bedtime

[taltamir]

Context

• KolMafia version: 19898
• Class: seal clubber, turtle tamer, and disco bandit tested. probably all
• Run type (Casual/Normal/Hardcore/Aftercore): hardcore
• Challenge Path (Standard/Path Name/None): none
• Number of Ascensions: 350+
• Are you using the beta version of autoscend?: beta

Expected/Desired Behavior

I am getting an infinite loop during doBedtime() in autoscend.ash specifically it is caused by the line (I know it is that line because commenting out that line bypasses the issue) kgbWasteClicks(); inside the function

if(possessEquipment($item[Kremlin\'s Greatest Briefcase]) && (get_property("_kgbClicksUsed").to_int() < 24))
    {
        kgbWasteClicks();
        int clicks = 22 - get_property("_kgbClicksUsed").to_int();
        if(clicks > 0)
        {
            auto_log_info("You have some KGB clicks (" + clicks + ") left!", "green");
        }
    }

I am not entirely sure why

the infinite loop in question does not involve anything new being printed to the CLI. It just remains stuck there until i hit esc to terminate autoscend.

i did have the briefcase initialized by my login script via ezandora's standalone briefcase script. which i use 3 times on login to give the commands unlock, collect, collect

Looking a the code for the function kgbWasteClicks(); inside auto_mr2017.ash I am not too sure why it would be doing this.

Of note that I had 17 clicks remaining at the time. And it had somehow failed to collect martinis despite sending the cli command briefcase collect; twice.

using the ezandora gui to collect the martinis and waste my remaining clicks worked.... its really acting weird.

[Malibu-Stacey]

TBH we should just use Ezandora's KGB script. We already rely on 5 of her scripts so a 6th won't make much difference.

[taltamir]

Is the current briefcase script a local copy of her briefcase script? or a completely independently developed one?

[Malibu-Stacey]

it's just some functions in auto_2017.ash, probably written by Cheesecookie as the git blame says it's all the initial commit by @soolar in the sl_ascend repo

[Malibu-Stacey]

Ezandora's KGB script is https://github.com/Ezandora/Briefcase

[taltamir]

Since ezandora does not update her scripts anymore... should we call it externally or add the files to integrate it natively? (allowing us to make changes to it)

[Malibu-Stacey]

Just add it as a dependency, same as the other 5 of her scripts we have dependencies on. I'd be surprised if it ever needs any changes. It's from 2017 so my guess is it's well tested by now.

[Malibu-Stacey]

See also #4 which can be fixed at the same time.

[taltamir]

Also encountered on heavy rains. Probably want to just switch to using ezandora's external script for the suitcase

[taltamir]

fixed #712