loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 67 forks source link

BETA: Pre-Adventure always fails pre-adventure if you don't own a Pet Coral familar #47

Closed macgregor closed 4 years ago

macgregor commented 4 years ago

Issue by AevumDecessus Monday Jul 08, 2019 at 13:53 GMT _Originally opened as https://github.com/soolar/sl_ascend/issues/270_


with sl_beta_test set to true, pre-adventures fails always with Starting preadventure script... You don't have a Pet Coral for a familiar., regardless if you even own a beach comb or not

macgregor commented 4 years ago

Comment by soolar Monday Jul 08, 2019 at 21:23 GMT


That's... bizarre. Pet Coral isn't referenced anywhere sl_ascend's codebase.

macgregor commented 4 years ago

Comment by Saklad5 Wednesday Jul 10, 2019 at 15:18 GMT


I can confirm this. I searched through the code upon encountering the issue, and came away similarly confused.

This is fairly easy to reproduce: it only seems to be an issue when doing the gremlins, and blacklisting Pet Coral alleviates the issue.

Those are probably the best leads: it is something to do with familiar handling for gremlins, and it acknowledges the blacklist.

macgregor commented 4 years ago

Comment by soolar Thursday Jul 18, 2019 at 22:54 GMT


This uhh... still happening? Still haven't observed it myself.

macgregor commented 4 years ago

temporary solution would seem to be hard coding pet coral into the blacklist for now.

Malibu-Stacey commented 4 years ago

I think this may have been a mafia bug that has since been fixed -> https://kolmafia.us/showthread.php?23943-July-2019-IotM-Beach-Comb&p=153398&viewfull=1#post153398

Closing for now.