search

loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 70 forks source link

HC LKS Pirate Quest Issues #472

Open c0mp13371331337 opened 4 years ago

c0mp13371331337 commented 4 years ago

Context

Expected/Desired Behavior

Get Frat outfit and complete quest

Current Behavior

Under certain conditions (?) Frat outfit isn't retrieved, and autoscend aborts after finishing the War with only pirate keys left before getting to the tower. Manually adventuring in the frat house for the outfit and then running autoscend will allow it to continue.

Failure Information (for bugs)

Will enable full debug and preference logging on the next ascension, just wanted to start the documentation.

Malibu-Stacey commented 4 years ago

It's not certain conditions, we just don't have any support for acquiring the items for anything other than Catburgling at the moment. When I added the Pirate handling, I assumed people would be going a Degrassi Knoll sign so we can buy the Frilly Skirt. Which moonsign are you choosing in Valhalla and are you using the rune spoon to tune to something else?

c0mp13371331337 commented 4 years ago

Oh interesting; I had assumed that it was encountering a certain condition where the outfit couldn't be retrieved, as I've only encountered this issue intermittently, probably only 25% - 35% of the time or so. Rest of the time it finishes the Pirate quest-line with no intervention. No catburgle, no rune spoon, and in Valhalla I'm choosing Opossum.

Malibu-Stacey commented 4 years ago

(Catburgling refers to the 3rd option in the NC btw not the familiar).

So what the code is supposed to do is see what methods you have available to get the dentures and use them. If you have none, it is supposed to try to acquire a Frilly Skirt either by buying one if you're in a Degrassi Knoll sign or adventuring at Degrassi Knoll Gym. Being 100% honest, I haven't tested anything other than a Degrassi Knoll sign.

A quick fix would be to add support for normal runs to pull a frilly skirt if you have the required hot wings for Catburgling (which since we have to adventure in Pandamonium Slums for the demonic key as well as doing the L6 quest is very likely). However this won't help you since you're in HC.

I suspect the reason it doesn't fail all the time for you is because the second option requires a mullet wig and a briefcase which you are likely acquiring while completing the level 11 quest (mullet wig comes from Whiteys Grove, briefcase from The Hidden Office). I guess the consumption code could be using up your hot wings to make devil hair pasta though if adventuring at Degrassi Knoll Gym is working as expected. I can add some code to stash 3 in your closet so that doesn't happen once I either confirm the Degrassi Knoll Gym adventuring works (or I fix it so it works).

My test account is currently in a run (Knoll sign obv) but I'll give a Canadia sign a test next.

Just out of interest, do you know how it's getting desert access for you? It should be trying to adventure in the Degrassi Knoll Garage for the meatcar parts or buying the bus pass if you have lots of meat on hand (like over 6k) and the code to adventure in the Garage is identical to the code to adventure in the Gym (I literally copy & pasted it then changed the zone).

A run log when it fails would be a great help btw as there's multiple possible things that could go wrong with this.

c0mp13371331337 commented 4 years ago

Without going back and combing through my logs, I'm guessing you're right about the second option. The 25-35% of the time that it fails for me is probably when it just doesn't happen to get the mullet wig and/or briefcase while routing through those locations.

Unsure how it's getting to the desert, but I can definitely search through my logs. Just let me know what to look for.

And I'm working on getting a run log, currently on Day 3 of a round of fresh HC LKS ascensions with debugging set to trace and preference change logging enabled. Will attach the log if any of my accounts run into the issue again.

Malibu-Stacey commented 4 years ago

BTW I added some extra info messages when we're trying to do the pirates on the beta branch which will help debug these issues.

c0mp13371331337 commented 4 years ago

Oh nice, thanks! I started today's runs with the updated beta branch. First account was right at the start of the war, and I noticed it started to spit out the extra info messages in the gCLI:

image

I'll not attempt any sort of manual intervention until the script runs out of other stuff to do, will keep you posted once the run finishes.

EDIT: Script finished the war, and at some point afterwards was able to complete enough of the pirate quest to get the associated keys. So this account won't run into the issue on this run, still have a few more accounts to test though.

c0mp13371331337 commented 4 years ago

Pirate Quest Run Log.txt

Here's a full session log after the script aborted without being able to complete the Pirate quest, with trace debugging and preference change logging enabled.

After manually getting the frat outfit and using the map to get the dentures, the script was able to continue the rest of the ascension without issue.