search

loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 67 forks source link

Not modfying combat for the Snowmen #527

Closed chunkinaround closed 4 years ago

chunkinaround commented 4 years ago

Context

Expected/Desired Behavior

Only adventure in Ninja Snowman lair if you can get +combat

Current Behavior

Current behavior seems to be that combat wont get modified if there is a delay burner available (in my and kobels case a goblin). I think this is true due to burningdelay getting set to true before we decide to modify combat. From auto_pre_adv.ash

    boolean burningDelay = (auto_voteMonster(true) || isOverdueDigitize() || auto_sausageGoblin());
    generic_t combatModifier = zone_combatMod(place);
    if (combatModifier._boolean && !burningDelay && !auto_haveQueuedForcedNonCombat()) {
        acquireCombatMods(combatModifier._int, true);
    }

In our case we had a goblin to burn, but nowhere left to burn it so burningDelay is true

Failure Information (for bugs)

Failure Logs

Relevant log snippet: Visiting the Trapper

[INFO] - Turn(513): Starting with 94 left at Level: 13 [INFO] - Encounter: 0.0 Exp Bonus: 5.197916666666666 [INFO] - Meat Drop: 135.0 Item Drop: 135.0 [INFO] - HP: 829/911, MP: 276/807, Meat: 45963 [INFO] - Tummy: 0/15 Liver: 0/20 Spleen: 0/15 [INFO] - ML: -25 control: 0 [INFO] - Delay between adventures... beep boop... [DEBUG] - Resetting auto_maximize_current to 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,3mp regen,1.5weapon damage,-0.75weapon damage percent,1.5elemental damage,2familiar weight,5familiar exp,-equip deceased crimbo tree,-equip broken champagne bottle,-equip makeshift garbage shirt **3BH note: showing that burningDelay will resolve true [WARNING] - Had overdue voting monster but couldn't find a zone to burn delay [WARNING] - Had overdue sausage but couldn't find a zone to burn delay 3BH note: Starting Simulation of whether I CAN adv at snowmen [INFO] - Checking if we can provide 25 positive combat rate, with equipment [DEBUG] - We currently have 0.0, so we need an extra 25.0 [DEBUG] - Adding "200combat 25max" to current maximizer statement [DEBUG] - Simulating: 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,3mp regen,1.5weapon damage,-0.75weapon damage percent,1.5elemental damage,2familiar weight,5familiar exp,-equip deceased crimbo tree,-equip broken champagne bottle,-equip makeshift garbage shirt,200combat 25max [DEBUG] - Adding "-equip Kramco Sausage-o-Matic™" to current maximizer statement [DEBUG] - Adding "effective" to current maximizer statement Maximizer: 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,3mp regen,1.5weapon damage,-0.75weapon damage percent,1.5elemental damage,2familiar weight,5familiar exp,-equip deceased crimbo tree,-equip broken champagne bottle,-equip makeshift garbage shirt,200combat 25max,-equip Kramco Sausage-o-Matic™,effective [DEBUG] - Removing "200combat 25max" from current maximizer statement [DEBUG] - With gear we can get to 0.0 [INFO] - I think we're good to go to apply Carlweather's Cantata of Confrontation [DEBUG] - We can gain Musk of the Moose, now we have 5.0 [DEBUG] - We can gain Carlweather's Cantata of Confrontation, now we have 10.0 3BH note: It has determined I can get up to +10 combat rate time to start the preadv [DEBUG] - Running auto_pre_adv.ash [INFO] - Starting preadventure script... [DEBUG] - Adventuring at Lair of the Ninja Snowmen [DEBUG] - lookupFamiliarDatafile is checking for type [drop] familiar Cat Burglar (34 lbs) [DEBUG] - Adding "-10ml" to current maximizer statement [DEBUG] - Adding "-equip Kramco Sausage-o-Matic™" to current maximizer statement [DEBUG] - Adding "effective" to current maximizer statement Maximizer: 5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,mox,-fumble,0.4hp,0.2mp 1000max,3mp regen,1.5weapon damage,-0.75weapon damage percent,1.5elemental damage,2familiar weight,5familiar exp,-equip deceased crimbo tree,-equip broken champagne bottle,-equip makeshift garbage shirt,-10ml,-equip Kramco Sausage-o-Matic™,effective 3BH note: It never entered providePlusCombat because it would have logged how much more it was looking for** equip hat wad of used tape equip off-hand latte lovers member's mug [DEBUG] - Going into High or Standard ML Zone with ML: -2 cast 1 Spirit of Cayenne You acquire an intrinsic: Spirit of Cayenne [INFO] - Pre Adventure at Lair of the Ninja Snowmen done, beep. [INFO] - HP: 829/861, MP: 276/808 Meat: 45963 [INFO] - Familiar: Cat Burglar @ 9 + 30lbs. [INFO] - ML: -25 Encounter: -10.0 Init: 160.0 [INFO] - Exp Bonus: 6.5249999999999995 Meat Drop: 369.6282894152753 Item Drop: 222.31414470763764 [INFO] - Resists: 11.0/13.0/11.0/11.0/13.0 threebullethamburgler_20200806.txt

Malibu-Stacey commented 4 years ago

That boolean burningDelay I added needs to check if we are actually burning delay, not just that we can.

chunkinaround commented 4 years ago

Can it be as simple as checking burnZone = $location[none] ? Thats what you use in LX_burnDelay

Malibu-Stacey commented 4 years ago

Fixed on beta in #528

Can it be as simple as checking burnZone = $location[none] ? Thats what you use in LX_burnDelay

pretty much.