Check the user hasn't ice housed something ascension relevant

[Malibu-Stacey]

@pastelmind mentioned in Discord that he'd forgotten he ice-housed the Pygmy Bowler before ascending and hadn't melted it which then caused autoscend to spend over 50 adventures in the Hidden Bowling Alley trying to complete the quest. We could add a simple check for a bunch of monsters we know are ascension relevant when in a run that the Ice House is allowed and abort if we find one so the user can go free the monster to continue (or play manually if they really want to keep that monster banished for some reason).

[taltamir]

I imagine the list is going to be very large... I have no actual opposition to it if someone else wants to write this though

[Alium58]

I can work on this one. I see it as a 2 step process:

1. Go to ice house. If can't, stop. If can, use a matcher function to capture name of monster
2. Hard code large list of ice houseable ascension required monsters and see if our ice housed monster is in that list

Questions

1. List to include only mandatory monsters, like pygmy bowler. Not to include helpful monsters like Smut Orc Pervert (if that is even banishable, just giving an example to show you the idea)
2. Is this the right approach?

[pastelmind]

Here's a list of banishable monsters that we probably don't want to banish, grouped by relevant council quests:

• L2: (none)
• L3: (none)
• L4: screambat, beanbat^{(enchanted bean for L10 quest)}
• L5: knob goblin harem girl^{(Harem Girl Disguise route)}
• L6: (none)
• L7: modern zmobie^❓, dirty old lihc
• L8: dairy goat
• L9: smut orc pervert^❓, bearpig topiary animal, elephant (meatcar?) topiary animal, spider (duck?) topiary animal
• L10: Quiet Healer^{(amulet and SGEEAs)}
• L11:
  • Hidden Temple/City: baa-relief sheep, pygmy bowler, pygmy shaman, pygmy witch accountant, pygmy witch surgeon
  • Spookyraven: animated ornate nightstand^{(Lord Spookyraven's spectacles)}, elegant animated nightstand, Cabinet of Dr. Limpieza, possessed wine rack, monstrous boiler, writing desk
  • Palindome: whitesnake, white lion
  • Zeppelin: man with the red buttons, red butler, red skeleton
  • Desert: banshee librarian^{(killing jar--debatable)}, blur^{drum machine}, tomb rat
• L12: (none)
• L13: (none)

❓: I don't know if these are actually affected by banishers

(This list is neither verified nor exhaustive; feel free to correct me)

Many of these monsters are not as important in Softcore since their drops can be pulled. An ideal implementation (not necessarily the prototype) could have an in_hardcore() check for them. I don't play softcore, though, so I don't know if autoscend actually pulls them.

[Alium58]

Thanks for the detailed list! Sorry for delayed response - real life has been busy and probs will continue to be. Agree with your approach of including helpful monsters and not just mandatory. Do you think the following are important enough to add to the list?

• L4: pine bat (stench resistance for new accounts)
• L8: ninja assassin ❓
• L10: burly sidekick
• L11:
  • Spookyraven: chalkdust wraith

Agreed some are less important in softcore. For now I'm going to keep it simple and not consider SC vs HC. Potentially could save a pull if a drop happens to happen.

I plan to include the question mark monsters in the check. No real harm besides a few extra CPU cycles.