2021-12-31 Nerf Day

[taltamir]

We need to update autoscend to work with the changes introduced in this nerf day.

TODO:

1. astral energy drinks should be consumed for Lucky
2. still need to add more new pulls to fill up the pull list.
3. bedtime pulling need to not pull disassembled clovers anymore since they are now useless. should instead pull a single 11 leaf clover
4. solve trying to pull 3 ores

Done:

982 rewrite olfaction

998 hotfix to disable consumption of lucky lindy and fortune cookies. Need to add them back in with the new mechanics.

1008 prevent duplicate pulls.

1007 acquire 11 leaf clovers from hermit

1010 support lucky adventures

[taltamir]

NERF DAY SUMMARY

thanks to everyone who stopped by the stream! lots of fun times. here is a summary of nerf day:

• SEMIRARES AND CLOVERS HAVE MERGED -- instead of separate clover/semirare adventures, the two adventure types have merged into "lucky" adventures, which appear when you have an intrinsic effect called "Lucky!". this effect comes from consuming an eleven leaf clover, a new item that all accounts can get 3 times a day from the hermit, every day. ten leaf clovers are useless for in-game purposes except as crafting fodder, and if you would like to craft clover things, you can now get ten-leaf clovers from fortune cookies. (old IOTMs relevant to semirares like lucky lindy, optimal dogs, and pillkeepers have not been updated yet; they will match the new system after this weekend!)
• ASTRAL ENERGY DRINKS ARE BACK -- AEDs are back in valhalla! they now are a 5-toxicity spleen item that gives you one charge of the new "Lucky!" intrinsic, essentially meaning you can turn spleen into the semirare/clover analogues.
• OLFACTION HAS... CHANGED -- from now on, you get three casts of olfaction per day, olfaction does not cost MP, and olfacting a monster never expires during your KoL day. it's an interesting change that will have large knock-on effects in both 1-day unrestricted and in usage of the tool in standard.
• HOOM HAH WON'T SCREW YOU! -- there is now a delay before the hoom hah NC is added to the forest encounter pool within the spooky forest. this way, you won't hit it in run anymore! what a dope time to be alive.
• PULL LISTS ARE FOREVER CHANGED -- in softcore (both standard and unrestricted), you can no longer pull more than 1 of a specific type of item per day. what this means is that of your 20 pulls per day, each pull must be a discrete and different item. this is going to add a lot of really cool strategic moves to standard, but it is -also- going to dramatically change old path softcore, as warskip is no longer possible anywhere. i think this is an interesting change, but what do i know, i'm just captain scotch.
• PAGODAS ARE MORE ANNOYING -- elf farm raffle tickets now do not respect "Lucky!" or clovers; you just have to roll them over and over to get your pagoda. sorry, loopers!
• MARMOT SUCKS NOW -- the marmot moonsign (previously +1 clover per day) now is +1 prismatic resistance. not great; from one of the strongest to one of the objectively weakest moonsigns. but don't worry, buddies, it could be worse! (3BH, do not read the next sentence.) you could have display case full of now useless moon spoons!

thanks Captain Scotch (#437479) for the above summary

[Alium58]

Thanks for making this. Thoughts on removing acquiring of clovers and eating fortune cookies while we work on these larger changes? Goal is to prevent script from going off the rails. Obviously will be less efficient until mafia and script get updated to fully support these changes.

Haven't looked at code yet so this may be a larger change but I think it should be a matter of commenting out a couple lines.

[taltamir]

Thanks for making this. Thoughts on removing acquiring of clovers and eating fortune cookies while we work on these larger changes? Goal is to prevent script from going off the rails. Obviously will be less efficient until mafia and script get updated to fully support these changes.

Haven't looked at code yet so this may be a larger change but I think it should be a matter of commenting out a couple lines.

Yea, I say go ahead and comment out that code. (it might be good to not outright delete it yet. since knowing where it went will be easier to fix it later).

[Alium58]

Thanks for making this. Thoughts on removing acquiring of clovers and eating fortune cookies while we work on these larger changes? Goal is to prevent script from going off the rails. Obviously will be less efficient until mafia and script get updated to fully support these changes. Haven't looked at code yet so this may be a larger change but I think it should be a matter of commenting out a couple lines.

Yea, I say go ahead and comment out that code. (it might be good to not outright delete it yet. since knowing where it went will be easier to fix it later).

Take a look at #998 . From my testing it is functional. We should merge it sooner rather than later as many folks are having issues atm

[Alium58]

Once #1010 is approved/merged I think we just have the updates to olfaction to do. Any thoughts on how to support this change? Maybe just reduce the list of monsters to sniff to the most valuable since we get less sniffs per day? Honestly don't know as I haven't used this skill much.

[taltamir]

Once #1010 is approved/merged I think we just have the updates to olfaction to do. Any thoughts on how to support this change? Maybe just reduce the list of monsters to sniff to the most valuable since we get less sniffs per day? Honestly don't know as I haven't used this skill much.

Yes, we should definitely reduce the sniff monster count to only the most important monsters.

Also we need to adjust the mechanics of how we handle on the trail. As it has become a non removeable intrinsic (or just super long lasting) that lasts until dayroll

> ash have_effect($effect[on the trail])

Returned: 2147483647

and we keep on trying to uneffect it. which fails

[taltamir]

@Alium58 my understanding was that #1010 was a partial fix. did you mean to have it automatically close this Issue on commit?

[Alium58]

@Alium58 my understanding was that #1010 was a partial fix. did you mean to have it automatically close this Issue on commit?

You're right there is more to fix. Didn't mean to have this closed. Definitely still learning GitHub. Wonder why this PR closed this issue while prior PRs did not. Ty for catching this

[taltamir]

You're right there is more to fix. Didn't mean to have this closed. Definitely still learning GitHub. Wonder why this PR closed this issue while prior PRs did not. Ty for catching this

because of Fixes #995 in the description of that PR if you go to #1010 and hover over the word "fixes" it will shot a tooltip informing you of that. need to be careful with putting a variety of words just before an issue number in PR descriptions if you do not want it auto closing them

[taltamir]

[INFO] Clover usage initialized
[DEBUG] Dont know how to unlock The Castle in the Clouds in the Sky (Top Floor)
[WARNING] Can't get to The Castle in the Clouds in the Sky (Top Floor) right now.
Wandering adventure interrupted our clover adventure (The Haunted Gallery).
Stack trace:
  at cloverUsageFinish (auto_util.ash:1432)
  at L12_themtharHills (level_12.ash:1704)
  at L12_islandWar (level_12.ash:2217)
  at LM_edTheUndying (actually_ed_the_undying.ash:1472)
  at process_tasks (autoscend.ash:1574)
  at doTasks (autoscend.ash:1770)
  at auto_begin (autoscend.ash:1904)
  at safe_preference_reset_wrapper (autoscend.ash:1934)
  at safe_preference_reset_wrapper (autoscend.ash:1941)

do not abort if lucky is interrupted by wandering monster. just try again

edit: actually this was not a wandering adventure. rather autoscend incorrectly thinks I unlocked the top floor when i didn't. I think this cropped up due to how #1010 was done. which was bound to happen. lots of changes were made.

[m-e-meyer]

Does there need to be a ticket to have autoscend use astral energy drinks for Lucky? My mistake, I saw clovers being used in yesterday's run instead of AEDs and thought autoscend didn't use the drinks. In that case, why not use an AED in preference to a clover? Seems to me that if it's a choice between using a clover that could easily be saved to the next day, or filling up unused spleen with an AED, one should go with the AED. Am I missing something?

[taltamir]

~Does there need to be a ticket to have autoscend use astral energy drinks for Lucky?~ My mistake, I saw clovers being used in yesterday's run instead of AEDs and thought autoscend didn't use the drinks. In that case, why not use an AED in preference to a clover? Seems to me that if it's a choice between using a clover that could easily be saved to the next day, or filling up unused spleen with an AED, one should go with the AED. Am I missing something?

A lot of times spleen does get used though. We need to check to see if spleen is actually useless before we decide to prefer AED over a clover. ... on the other hand, the fact that we took AED might suggest we lack good spleen items. so maybe it is worthwhile

[m-e-meyer]

I guess you know by now it's an astral energy drink

-- Sent from Aventuristo's iPad

On Feb 12, 2022, at 12:44 PM, taltamir @.***> wrote:

 Does there need to be a ticket to have autoscend use astral energy drinks for Lucky? My mistake, I saw clovers being used in yesterday's run instead of AEDs and thought autoscend didn't use the drinks. In that case, why not use an AED in preference to a clover? Seems to me that if it's a choice between using a clover that could easily be saved to the next day, or filling up unused spleen with an AED, one should go with the AED. Am I missing something?

what is an AED?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.

[Malibu-Stacey]

Looks like this is all done.