Closed ziz closed 6 months ago
First of all: great bug report!! This is stellar stuff.
Second of all: the actual issue here is a little weirder. That first macro is meant to fire on autoattack; that second macro is a fallthrough case designed for a few extremely specific weird scenarios that happen due to quirks with kolmafia's autoattack. The real issue here is that you got the jump and your autoattack didn't trigger, which means you didn't have the autoattack special monsters flag set to true.
But garbo's supposed to do it for you. It uses libram's setCombatFlags
API as of somewhat recently, which appears to be missing a few URL params. Whoops!
I'm cutting a new libram now that includes the necessary &ajax=1&am=1
, and will merge it to garbo shortly.
Before Reporting Ensure that KoLMafia and garbo are both up to date before reporting a bug. If you have installed mafia in a weird or non-standard way, let us know any details about that here. But also, if you've installed mafia in a weird or non-standard way, I'm telling you right now that that's your bug. Also, check existing github issues to see if this has already been reported. If it has, consider leaving a comment with any additional information you can give on that issue, instead of making a new one.
Also, read this.
Describe the bug Getting the jump on a wandering embezzler during barf mountain turns causes the combat macro to abort.
Using Mafia r27840, and up-to-date garbo:
To Reproduce Steps to reproduce the behavior:
Seems like: have equipment such that you fight a wandering knob goblin embezzler - in my case, a romantic copy - during barf turns, with enough initiative to get the jump on it.
I don't know what causes this setup particularly to occur; if I had to guess, I'd think it's because my number of copies exceeded free fights available; this is possibly because I ran my NEP and Shadow Rift freebies manually before starting garbo.
Expected behavior The combat proceeds normally rather than aborting.
Session Log Attach a full KoLMafia session log from the day you encountered the bug. Include details about when in the log the bug occurred to help developers rapidly find the error. Copy and paste any associated red text printed to the gCLI during this error.
Additional context
I picked up a couple of new toys since my last run of Garbo - a songboom boom box and a packaged backup camera.
Full session log: sepos_20240301_garbobug.txt
The abort seems to be coming from this combat macro setup: https://github.com/loathers/garbage-collector/blob/2985cb09430e1f779d2cf262f112edcd94e62df4/packages/garbo/src/tasks/barfTurn.ts#L663-L669
which looks like it was added by e51bae9fa1fa538fe7865059f81c0a640ffb7780.
I'm not sure what debug log at line 4329 of the session was about. I restarted garbo and it was fine afterwards.
There was an abort at line 10812 which I ran a combat macro against as basic troubleshooting without issue, then restarted garbo.
The abort in question was at line 13066.
gCLI output for the abort under fold
modtrace init output
type | source | Initiative | Initiative Penalty -- | -- | -- | -- Effect | Bastille Braggadocio | +25.00 | = +25.00 | | Effect | Springy Fusilli | +40.00 | = +65.00 | | Effect | Shadow Waters | +100.00 | = +165.00 | |
generated ccs macro
``` if (monsterid 530) && !gotjump && !(pastround 2);if hasskill Sing Along;skill Sing Along;endif;if hasskill Bowl Straight Up;skill Bowl Straight Up;endif;if monstername angry tourist || monstername garbage tourist || monstername horrible tourist family || monstername Knob Goblin Embezzler || monstername sausage goblin;while !hppercentbelow 25 && monsterhpabove 5 && !pastround 20;use facsimile dictionary;endwhile;endif;if hasskill Summer Siesta;skill Summer Siesta;endif;while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;attack;endwhile;while hasskill Saucegeyser;skill Saucegeyser;endwhile;while hasskill Weapon of the Pastalord;skill Weapon of the Pastalord;endwhile;while hasskill Cannelloni Cannon;skill Cannelloni Cannon;endwhile;while hasskill Wave of Sauce;skill Wave of Sauce;endwhile;while hasskill Saucestorm;skill Saucestorm;endwhile;while hasskill Northern Explosion && snarfblat 567;skill Northern Explosion;endwhile;while hasskill Lunging Thrust-Smack && !snarfblat 567;skill 1005;endwhile;attack;repeat;endif;abort; ```