[BUG] Failed to maximize properly

[Bioblade]

Before Reporting KoLmafia version r27849 Garbo is up to date

Describe the bug Garbo reaches preparing to perform Barf mountain runs, and upon attempting to maximize for these runs, returns the error "Failed to maximize properly!" before ending prematurely.

To Reproduce

1. Activate the Garbo script within Mafia by typing the command "garbo".
2. Wait for Garbo's scripting to execute.
3. Garbo returns "Error: Failed to maximize properly!" after a period of time.

Expected behavior Garbo continues to use all adventures for scripted farming.

Session Log Error occurs at the end of the logged activity. Bioblade64_20240306.txt

JavaScript exception: Error: Failed to maximize properly! (file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js#28688) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:28688 (_dress) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:28685 (_dress) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:28760 (dress) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:39227 (getCachedOutfitValues) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:39296 (calculateOutfitValue) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:39309 (barfFamiliar) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:33490 (barfOutfit) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:45284 at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:1107 (undelay) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:29329 (createOutfit) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:29218 (execute) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:47977 (execute) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:29156 (run) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:48034 (runGarboTasks) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:48040 (runGarboQuests) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:48503 at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:40274 (withClan) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:40268 (withVIPClan) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:48474 at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:40253 (withStash) at file:/D:/My%20Drive/KOLMafia/scripts/garbage-collector/garbo.js:48473 (main)

Additional context This may be relevant to the scripting mishap from a few days ago as listed in bug #1817. I did use the temporary fix listed in the comments of it, using the commands "set _monsterHabitatsRecalled=3 and set _monsterHabitatsFightsLeft=0". Outside of those, I have not changed other garbo parameters outside of what is recommended in the official guide on the home page.

[s-k-z]

When it breaks on "Failed to maximize properly!", you should open up the maximizer and re-run the query to see what the equipment selected by KoLmafia is.

Confirm that you have sufficient quantities of all of the equipment in your inventory. If you don't, make sure you are out of combat, then you can try refresh all in the KoLmafia graphical CLI, or fully exit and relaunch KoLmafia to reload your inventory and equipment. Usually this type of error stems from KoLmafia miscounting your equipment.

[Bioblade]

I'm assuming that that would be done from the modifier maximizer menu and selecting "update" after encountering the error in garbo, and then inputting "refresh all" in the CLI and running garbo again. In which case, the error still seems to occur. That being said, there is an issue where KoL is repeatedly trying to use a makeshift crane even when there is already that familiar in the terrarium, and I can manually trigger that same response when selecting "fold & equip back makeshift cape", which I would have assumed would use the "fold" option rather than the "grow" option to make said cape. Is this an issue with the maximizer?

[Bioblade]

Folding a makeshift crane into a cape from in-game seems to have fixed the issue. Was probably as issue with the maximizer distinguishing folding from growing.