Open yojimboslaw opened 2 months ago
horrible-little-slime
commented
2 months ago We only should attempt to use the time-spinner if mafia thinks the appropriate monster is in your combatQueue in noob cave, the dire warren, or the haunted kitchen--can you check ash $location[].combat_queue for those locations?
Losing a fight should still queue combats, right?
eric-the-redbeard
commented
2 months ago I checked the generated combat macro, it looks like it is testing for a different monster (garbage tourist, 1760) from within the test for the witchess monster (bishop in my case, 1942), with no apparent attempt at converting a monster. It is also testing twice for lay an egg (7494) and emit matter duplicating drones. It also has an empty test for Briny Deeps (column 1340 unformatted, line 75 formatted).
I'm not sure how to contribute further.
Here is the generated combat macro (blob first, then repeated with line breaks and indentions): if (monsterid 1622 || monsterid 1965);while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;attack;endwhile;if hasskill Saucegeyser;skill Saucegeyser;repeat hasskill Saucegeyser;endif;if hasskill Weapon of the Pastalord;skill Weapon of the Pastalord;repeat hasskill Weapon of the Pastalord;endif;if hasskill Cannelloni Cannon;skill Cannelloni Cannon;repeat hasskill Cannelloni Cannon;endif;if hasskill Wave of Sauce;skill Wave of Sauce;repeat hasskill Wave of Sauce;endif;if hasskill Saucestorm;skill Saucestorm;repeat hasskill Saucestorm;endif;if hasskill Northern Explosion;skill Northern Explosion;repeat hasskill Northern Explosion;endif;if hasskill 1005;skill 1005;repeat hasskill 1005;endif;attack;repeat;endif;if monsterid 1942;if snarfblat 186;endif;if monsterid 1942;if hasskill 7494;skill 7494;repeat hasskill 7494;endif;endif;if monsterid 1942;if hasskill Emit Matter Duplicating Drones;skill Emit Matter Duplicating Drones;endif;endif;if hasskill 7485;skill 7485;endif;if hasskill 7486;skill 7486;endif;if monsterid 1942;if hasskill 7526;skill 7526;endif;endif;if monsterid 1942;if hasskill 7494;skill 7494;repeat hasskill 7494;endif;endif;if monsterid 1942;if hasskill Emit Matter Duplicating Drones;skill Emit Matter Duplicating Drones;endif;endif;if hasskill Bowl Straight Up;skill Bowl Straight Up;endif;if monsterid 1760;if hasskill Transcendent Olfaction;skill Transcendent Olfaction;endif;endif;if monsterid 1760;if hasskill Gallapagosian Mating Call;skill Gallapagosian Mating Call;endif;endif;if monstername angry tourist || monstername garbage tourist || monstername horrible tourist family || monstername Witchess Bishop || monstername sausage goblin;if !hppercentbelow 25;if hasskill Pocket Crumbs;skill Pocket Crumbs;endif;endif;if !hppercentbelow 25;if hascombatitem porquoise-handled sixgun;use porquoise-handled sixgun;endif;endif;while !hppercentbelow 25 && !pastround 20;use seal tooth;endwhile;endif;while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;attack;endwhile;if hasskill Saucegeyser;skill Saucegeyser;repeat hasskill Saucegeyser;endif;if hasskill Weapon of the Pastalord;skill Weapon of the Pastalord;repeat hasskill Weapon of the Pastalord;endif;if hasskill Cannelloni Cannon;skill Cannelloni Cannon;repeat hasskill Cannelloni Cannon;endif;if hasskill Wave of Sauce;skill Wave of Sauce;repeat hasskill Wave of Sauce;endif;if hasskill Saucestorm;skill Saucestorm;repeat hasskill Saucestorm;endif;if hasskill Northern Explosion;skill Northern Explosion;repeat hasskill Northern Explosion;endif;if hasskill 1005;skill 1005;repeat hasskill 1005;endif;attack;repeat;endif;abort "Macro for Fax expected Witchess Bishop but encountered something else.";
formatted:
if (monsterid 1622 || monsterid 1965);
while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;
attack;
endwhile;
if hasskill Saucegeyser;
skill Saucegeyser;
repeat hasskill Saucegeyser;
endif;
if hasskill Weapon of the Pastalord;
skill Weapon of the Pastalord;
repeat hasskill Weapon of the Pastalord;
endif;
if hasskill Cannelloni Cannon;
skill Cannelloni Cannon;
repeat hasskill Cannelloni Cannon;
endif;
if hasskill Wave of Sauce;
skill Wave of Sauce;
repeat hasskill Wave of Sauce;
endif;
if hasskill Saucestorm;
skill Saucestorm;
repeat hasskill Saucestorm;
endif;
if hasskill Northern Explosion;
skill Northern Explosion;
repeat hasskill Northern Explosion;
endif;
if hasskill 1005;
skill 1005;
repeat hasskill 1005;
endif;
attack;
repeat;
endif;
if monsterid 1942;
if snarfblat 186;
endif;
if monsterid 1942;
if hasskill 7494;
skill 7494;
repeat hasskill 7494;
endif;
endif;
if monsterid 1942;
if hasskill Emit Matter Duplicating Drones;
skill Emit Matter Duplicating Drones;
endif;
endif;
if hasskill 7485;
skill 7485;
endif;
if hasskill 7486;
skill 7486;
endif;
if monsterid 1942;
if hasskill 7526;
skill 7526;
endif;
endif;
if monsterid 1942;
if hasskill 7494;
skill 7494;
repeat hasskill 7494;
endif;
endif;
if monsterid 1942;
if hasskill Emit Matter Duplicating Drones;
skill Emit Matter Duplicating Drones;
endif;
endif;
if hasskill Bowl Straight Up;
skill Bowl Straight Up;
endif;
if monsterid 1760;
if hasskill Transcendent Olfaction;
skill Transcendent Olfaction;
endif;
endif;
if monsterid 1760;
if hasskill Gallapagosian Mating Call;
skill Gallapagosian Mating Call;
endif;
endif;
if monstername angry tourist || monstername garbage tourist || monstername horrible tourist family || monstername Witchess Bishop || monstername sausage goblin;
if !hppercentbelow 25;
if hasskill Pocket Crumbs;
skill Pocket Crumbs;
endif;
endif;
if !hppercentbelow 25;
if hascombatitem porquoise-handled sixgun;
use porquoise-handled sixgun;
endif;
endif;
while !hppercentbelow 25 && !pastround 20;
use seal tooth;
endwhile;
endif;
while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;
attack;
endwhile;
if hasskill Saucegeyser;
skill Saucegeyser;
repeat hasskill Saucegeyser;
endif;
if hasskill Weapon of the Pastalord;
skill Weapon of the Pastalord;
repeat hasskill Weapon of the Pastalord;
endif;
if hasskill Cannelloni Cannon;
skill Cannelloni Cannon;
repeat hasskill Cannelloni Cannon;
endif;
if hasskill Wave of Sauce;
skill Wave of Sauce;
repeat hasskill Wave of Sauce;
endif;
if hasskill Saucestorm;
skill Saucestorm;
repeat hasskill Saucestorm;
endif;
if hasskill Northern Explosion;
skill Northern Explosion;
repeat hasskill Northern Explosion;
endif;
if hasskill 1005;
skill 1005;
repeat hasskill 1005;
endif;
attack;
repeat;
endif;
abort "Macro for Fax expected Witchess Bishop but encountered something else.";I'm confused, is the issue that the combat macro is too long or that you're having trouble with the time-spinner?
Arashmin
commented
1 month ago I think it's the former - I'm also getting a daily witchess death, but on the Witchess Set itself.
ianknowles
commented
1 month ago I think macro being too long is a generic issue. I see a macro abort daily on purple copies. Its usually a witchess piece but for me thats just because its been selected as the copy target. Its been doing the same whatever the purple copy is since release of the candle. I'll grab what it generates today.
ianknowles
commented
1 month ago "if (monsterid 1622 || monsterid 1965);while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;attack;endwhile;if !monsterid 1858;if hasskill Northern Explosion;skill Northern Explosion;repeat hasskill Northern Explosion;endif;endif;if hasskill 1005;skill 1005;repeat hasskill 1005;endif;if hasskill Saucegeyser;skill Saucegeyser;repeat hasskill Saucegeyser;endif;if hasskill Weapon of the Pastalord;skill Weapon of the Pastalord;repeat hasskill Weapon of the Pastalord;endif;if hasskill Cannelloni Cannon;skill Cannelloni Cannon;repeat hasskill Cannelloni Cannon;endif;if hasskill Wave of Sauce;skill Wave of Sauce;repeat hasskill Wave of Sauce;endif;if hasskill Saucestorm;skill Saucestorm;repeat hasskill Saucestorm;endif;attack;repeat;endif;if monsterid 1936;if snarfblat 186;if hascombatitem pulled green taffy;use pulled green taffy;endif;endif;if monsterid 1936;if hasskill 7494;skill 7494;repeat hasskill 7494;endif;endif;if hasskill 7485;skill 7485;endif;if hasskill 7486;skill 7486;endif;if hascombatitem Spooky Putty sheet;use Spooky Putty sheet;endif;if hascombatitem Rain-Doh black box;use Rain-Doh black box;endif;if hascombatitem unfinished ice sculpture;use unfinished ice sculpture;endif;if monsterid 1936;if hasskill 7526;skill 7526;endif;endif;if monsterid 1936;if hasskill 7494;skill 7494;repeat hasskill 7494;endif;endif;if hasskill Bowl Straight Up;skill Bowl Straight Up;endif;if monsterid 1760;if hasskill Transcendent Olfaction;skill Transcendent Olfaction;endif;endif;if monsterid 1760;if hasskill Gallapagosian Mating Call;skill Gallapagosian Mating Call;endif;endif;if monsterid 1760;if hasskill Offer Latte to Opponent;skill Offer Latte to Opponent;endif;endif;if (monsterid 1758 || monsterid 1760 || monsterid 1759 || monsterid 1936 || monsterid 2104);if !hppercentbelow 25;if hasskill Pocket Crumbs;skill Pocket Crumbs;endif;endif;if !hppercentbelow 25;if hascombatitem porquoise-handled sixgun;use porquoise-handled sixgun;endif;endif;while !hppercentbelow 25 && !pastround 20;use facsimile dictionary;endwhile;endif;while !pastround 24 && !hppercentbelow 25 && !missed 1 && !snarfblat 567;attack;endwhile;if !monsterid 1858;if hasskill Northern Explosion;skill Northern Explosion;repeat hasskill Northern Explosion;endif;endif;if hasskill 1005;skill 1005;repeat hasskill 1005;endif;if hasskill Saucegeyser;skill Saucegeyser;repeat hasskill Saucegeyser;endif;if hasskill Weapon of the Pastalord;skill Weapon of the Pastalord;repeat hasskill Weapon of the Pastalord;endif;if hasskill Cannelloni Cannon;skill Cannelloni Cannon;repeat hasskill Cannelloni Cannon;endif;if hasskill Wave of Sauce;skill Wave of Sauce;repeat hasskill Wave of Sauce;endif;if hasskill Saucestorm;skill Saucestorm;repeat hasskill Saucestorm;endif;attack;repeat;endif;abort "Macro for Witchess expected Witchess Knight but encountered something else.";"
darkaxz
commented
1 month ago I've also been getting stuck here recently. It generates different errors seemingly randomly, though, instead of just the too-long combat macro like "failed to maximize properly" or "Macro for Time-Spinner expected Witchess Knight but encountered something else" or something along the lines of "Tried to access Witchess set but couldn't". When I open the relay browser it's always in the time-spinner monster choice adventure and I have to manually back out and go to my Witchess set myself. If the farming macro is still active, it'll usually behave after I kill one (or two if it auto-does the purple copy) manually. The other day I had 1 time-spinner minute remaining and it got stuck anyway and I had to waste it on something non-essential for the script to work again.
So I'm not sure if it's always the combat macro or something in general with how the Time-Spinner forgets old fights and it doesn't properly back out of the choice adventure before trying something else.
Edit: After one of the recent updates it doesn't seem to get stuck for me anymore, fingers crossed.
Describe the bug I think garbo is failing combat against witchess things with an overlong macro leading it to get stuck in the timespinner choice when it's unable to find the witchess thing it wants to copy there (because it didn't win). This may be a duplicate of Arashmin's bug, sorry if so.
To Reproduce "garbo" in CLI and wait until it gets stuck in the timespinner choice.
Expected behavior Garbo should not fail combat. Session Log portion of gCLI output preceding macro error and error message output:
Additional context Session results indicate "Combat: Witchess Knight (1)", but the timespinner's dropdown does not contain this (although it does contain a rook). Edit: manually defeating a witchess knight makes the script run, until it wants a witchess bishop from the timespinner. :)