[BUG] Holiday Wanderer Handling at Barf

[VuvuzelaVirtuoso]

Describe the bug Garbo encounters holiday wanderers while in Barf Mountain and aborts.

Executing Barf Turn/Barf

Visit to Dinseylandfill: Barf Mountain in progress...

[1015] Barf Mountain
Preference lastEncounter changed from garbage tourist to El Novio Cadáver
Encounter: El Novio Cadáver
Preference relayCounters changed from 1018:Holiday Monster window end loc=* type=wander:rparen.gif to
Preference relayCounters changed from to 1039:Holiday Monster window begin loc=*:lparen.gif
Preference relayCounters changed from 1039:Holiday Monster window begin loc=*:lparen.gif to 1039:Holiday Monster window begin loc=*:lparen.gif:1049:Holiday Monster window end loc=* type=wander:rparen.gif
Round 0: vuvuzela virtuoso wins initiative!
Preference cosmicBowlingBallReturnCombats changed from 13 to 12
Round 1: Your toy train moves ahead to the Coal Hopper. Your train takes on coal to power the next stop.
Preference trainsetPosition changed from 914 to 915
Round 1: vuvuzela virtuoso executes a macro!
KoLmafia thinks it is round 2 but KoL thinks it is round 1
You're on your own, partner. (Macro Aborted ("abort"))
[Click here to continue in the relay browser.](https://github.com/loathers/garbage-collector/issues/main.php)

To Reproduce Encounter holiday wanderer while barfing. (happened with Dia de Los Muertos and Boris, not with Pirate though).

Expected behavior For wanderer to be dealt with in way that prevents abort.

Session Log

You're on your own, partner. (Macro Aborted ("abort"))
[Click here to continue in the relay browser.](https://github.com/loathers/garbage-collector/issues/main.php)

vuvuzela_virtuoso_20240923.txt

Additional context None.

[horrible-little-slime]

@VuvuzelaVirtuoso did you recently acquire the Monster Manuel

Because if I had to guess the issue is that you don't have enough factoids for cadavers and do have enough factoids for pirates, meaning that you can't yet use the monsterhpabove macro predicate

[VuvuzelaVirtuoso]

Nope, had one since February 14th, 2023. I've played every day since the beginning of 2023 so I should've gotten factoids for holiday wanderers by now, and I've had no issues running scripts like garbo on previous holidays like FoB and Dia de Los Muertos Borrachos.

[horrible-little-slime]

Can you share your pirate day log?

On Thu, Sep 26, 2024, 4:49 PM VuvuzelaVirtuoso @.***> wrote:

Nope, had one since February 14th, 2023. I've played every day since the beginning of 2023 so I should've gotten factoids for holiday wanderers by now, and I've had no issues running scripts like garbo on previous holidays like FoB and Dia de Los Muertos Borrachos.

— Reply to this email directly, view it on GitHub https://github.com/loathers/garbage-collector/issues/2127#issuecomment-2377911061, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZNQVMUSDBQ7MGQ65LKZ3DZYRXPBAVCNFSM6AAAAABOVOWBHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXHEYTCMBWGE . You are receiving this because you commented.Message ID: @.***>

[VuvuzelaVirtuoso]

Sure, that's attached here:

vuvuzela_virtuoso_20240919.txt

[VuvuzelaVirtuoso]

Also attaching my log from the last FoB where I was seeing the same issues as I ultimately had with the Cadavers.

vuvuzela_virtuoso_20240811.txt

[VuvuzelaVirtuoso]

And for excessiveness' sake, here's a lot from the FoB back in Feb where Garbo was just fine for me. (The one in May I was in long aftercore for, and didn't visit Barf) vuvuzela_virtuoso_20240201.txt

[horrible-little-slime]

To whoever looks at this next: this is the only commit I can see that happened between pirate day and el dia de los muertos that could affect it, which seems unlikely to matter given that the macros look basically the same:

The other difference I notice is that in a successful pirate combat we see

Round 0: vuvuzela virtuoso wins initiative!
Preference cosmicBowlingBallReturnCombats changed from 3 to 2
Round 0: vuvuzela virtuoso casts SING ALONG!
Round 1: Your toy train moves ahead to the Ore Hopper Feeder. Some ore pours of the feeder into the hopper of your train.
Preference trainsetPosition changed from 879 to 880
You acquire an item: cardboard ore

whereas in the unsuccessful cadaver combat we see

Round 0: vuvuzela virtuoso wins initiative!
Preference cosmicBowlingBallReturnCombats changed from 12 to 11
Round 1: Your toy train moves ahead to the Ore Hopper Feeder. Some ore pours of the feeder into the hopper of your train.
Preference trainsetPosition changed from 853 to 854
You acquire an item: bubblewrap ore
Round 1: vuvuzela virtuoso executes a macro!

so that suggests there could be an issue with autoattack against special monsters here.

Mafia data suggests neither are bosses, the main difference I see is that cadavar is nocopy and pirate isn't.