search

loathers / greenbox

Script for examining and sharing a player's loadout of skills and items in the Kingdom of Loathing
https://greenbox.loathers.net
Apache License 2.0
6 stars 7 forks source link

Wrong Tattoo #80

Closed jaadams5 closed 3 months ago

jaadams5 commented 3 months ago

Greenbox reports that a never-ascended character has "G-Lover Gattoo" as a tattoo. The character doesn't have it. Greenbox fails to show the Guzzlr tattoo which the character does have,

Perhaps of interest, av-snapshot does not show a G-Lover tattoo and has something it calls "Guzzlr Tattoo 2" which it thinks the character does not have.

https://greenbox.loathers.net/?u=215957

https://api.aventuristo.net/av-snapshot?u=fronobulax#a1b

Thank you.

gausie commented 3 months ago

Could you send me the contents of your account_tattoos.php?

On Tue, 21 May 2024 at 14:30, Jamie Adams @.***> wrote:

Greenbox reports that a never-ascended character has "G-Lover Gattoo" as a tattoo. The character doesn't have it. Greenbox fails to show the Guzzlr tattoo which the character does have,

Perhaps of interest, av-snapshot does not show a G-Lover tattoo and has something it calls "Guzzlr Tattoo 2" which it thinks the character does not have.

https://greenbox.loathers.net/?u=215957

https://api.aventuristo.net/av-snapshot?u=fronobulax#a1b

Thank you.

— Reply to this email directly, view it on GitHub https://github.com/loathers/greenbox/issues/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABL4LSNTCAJQASNJ5L6LPLZDND6DAVCNFSM6AAAAABIBT2H72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDQMZRHE4DCMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jaadams5 commented 3 months ago

account_tattoos.php.html.txt

OK?

gausie commented 3 months ago

account_tattoos.php.html.txt

OK?

No, you've hit save on the KoLmafia relay browser here which is doubly wrong. Please either get it from KoLmafia debug log, or directly from the KoL website and just View Source, copy and paste.

jaadams5 commented 3 months ago

"" extracted.

body.txt

The debug log had more info than I expect you needed. If this is still not what you want I'll try again tomorrow.

gausie commented 3 months ago

This is still wrong - you need to get it from viewing source or from the KoLmafia debug log. I will generate some test data myself as I know what the issue is now.

gausie commented 3 months ago

Actually no, replicating your exact situation isn't trivial, it would be great for you to provide the actual HTML.

Just for an update, writing a test suite for Greenbox necessitated an update to libram, which wasn't merged until now. I believe I've now fixed at least half of your issue. Please get me the HTML and I'll make sure everything is right.

jaadams5 commented 3 months ago

Thank you. It was frustrating to not understand and follow directions.

The previous file was created by viewing the profile in the relay browser, turning on mafia debug, selecting the view your tattoos link and then turning off debug. I then used an editor to isolate what was between body tags.

I logged into plain vanilla KOL, navigated to the page, displayed the tattoos and then did a Save from the tattoo frame. That produced a single HTML file and a subdirectory containing a number of files, many of which were images, but not all. If we have to do this again what would you like? In the absence of any guidance I will create a clean subdirectory, save to there and then zip up the formerly clean subdirectory.

I'm using Brave on Windows 10 Home. I could easily try the same thing in Microsoft Edge if that is needed.

Please advise if "Please get me the HTML and I'll make sure everything is right." still applies and I will try and get what you need.

Thank you.

gausie commented 3 months ago

@jaadams5 as I said in my first request

Please either get it from KoLmafia debug log, or directly from the KoL website and just View Source, copy and paste.

Both files that you sent were generated using the browser's save feature. It's very clear that none of it comes from the KoLmafia debug log, nor from viewing source on vanilla KoL.

Getting the HTML from either of those sources would still be appreciated.

jaadams5 commented 3 months ago

There has to be a vocabulary issue or an unspoken assumption.

I just did the following:

Started up KoLmafia. Logged in. Opened the mini-browser. Entered "account_tattoos.php" in the "go" bar. (Tattoo page displayed when I hit enter in the field. I did not press go). Used "Start Debug Log" from the Help menu. Pressed the refresh icon in the mini-browser (and saw the page refresh). Used "Stop Debug Log" from the help menu. Uploaded DEBUG_20240605.txt.

DEBUG_20240605.txt

I had previously done that except I used the Relay Browser to navigate to the Tattoo page and then a text editor to remove material that was not contained in a BODY tag. This debug log is unedited.

One of the previous attempts did not use a browser Save As command. I used Debug On, Debug Off and then a text editor but my editing or editor could have changed something important.

So if this file is not what you want then I need step by step instructions, please.

gausie commented 3 months ago

That simply cannot be the case. Every file posted to this issue before now was sourced from "Save As". I suspect you uploaded the wrong file by mistake.

The most recent upload is correct though, thank you.

jaadams5 commented 3 months ago

OK. I'll chalk up another one to faulty memory. Glad this works, which is really all that matters. Thanks.