loathers / grimoire

Apache License 2.0
3 stars 8 forks source link

Autoattack handling in combat strategy behaves very, very differently to regular macros #76

Open horrible-little-slime opened 1 year ago

horrible-little-slime commented 1 year ago

compileAutoattack has nothing in it that supports starting_macro or ActionDefaults and this is, as far as I can tell, undocumented. It also doesn't appear to have any analogues thereof.

Kasekopf commented 1 year ago

I would say it is somewhat documented here that autoattack only includes macros from .autoattack(), and not anything that was added to the normal macro. But I agree the current autoattack handling is not very complete, especially with respect to CombatActions.

I am definitely open to adding better autoattack handling. At one point I got partly through some code that added an EngineOption to copy the result of CombatStrategy.compile onto the end of the compiled autoattack. But I got stuck on how to figure out if the autoattack has already triggered before running the CombatStrategy.compile macro again (since we would want to throw an Exception if the autoattack has already triggered but the fight is not over, probably).