Make `updateOverlappingItemSkillNames` use gausie's hot new data-of-loathing API, and only trigger when we're building for a release

loathers / libram

libram is a Typescript library that intends to provide comprehensive support for automating KoLmafia

https://loathers.github.io/libram

9 stars 23 forks source link

Make `updateOverlappingItemSkillNames` use gausie's hot new data-of-loathing API, and only trigger when we're building for a release #573

Open horrible-little-slime opened 4 months ago

horrible-little-slime commented 4 months ago

Right now, updateOverlappingItemSkillNames hits kolmafia's github directly, and seems to fire pretty often. Sorry!

The former is dangerous because if kolmafia changes the way it encodes data, we can get build issues--this happened a little while ago. data-of-loathing is more deliberately safeguarded against that. We could just apply those safeguards here, but why would we do that when we could instead rely on this beautiful tool.

The latter isn't dangerous, but it is wasteful.

Rinn commented 1 month ago

what if we just forced combat macros to always use ids? we wouldn't need that at all if so.