lob / lob-php

PHP Client for Lob API
https://lob.com
MIT License
67 stars 21 forks source link

edit addresses+bankaccs integration tests #144

Closed jho44 closed 2 years ago

jho44 commented 2 years ago

ticket

Got rid of all the try catches because:

  1. If the API does fail, don't we want it to break the tests rather than just print the errs?
  2. The tests stop upon hitting an exception so nothing gets printed.

Done:

sudoku-lord commented 2 years ago

@BennyKitchell what is your opinion?

jho44 commented 2 years ago

@BennyKitchell what is your opinion?

Benny said we could go either way, but if something like a 200 is failing, then we def want it to break the test. So I'll just throw some throws in.