Pass through proxy to rest-client if supplied

lob / lob-ruby

Ruby Wrapper for Lob API

lob.com

MIT License

97 stars 43 forks source link

Pass through proxy to rest-client if supplied #203

Closed drcapulet closed 2 years ago

ShariqT commented 2 years ago

Thanks for using Lob! I'll take a look as to why the tests are failing and get back to you.

colin-garcia commented 2 years ago

Hey @ShariqT thanks for looking into this. Any updates on the test failures?

ShariqT commented 2 years ago

@colin-garcia This was something on our end when moving from TravisCI to GH Actions. We needed to setup a workflow around managing PRs from forked repos. Forked repos don't have access to the repo secrets, which means that tests aren't going to run correctly. I looked this PR and all of the test pass, so we are good. It will be merged.

colin-garcia commented 2 years ago

Thank you so much @ShariqT!