add campaigns - Githubissues

lob / lob-typescript-sdk

MIT License

11 stars 7 forks source link

add campaigns #237

Closed jho44 closed 2 years ago

jho44 commented 2 years ago

Description

Regenerated SDK, but took out stuff like Creatives API, Uploads API, Default API, related models, etc. Added Campaigns API, related models, and unit/integration tests.

Story

JIRA-1266

Related PR's

Generator PR 1 Generator PR 2

Verify

[x] Code runs without errors
[x] Tests pass with >=85% coverage

BennyKitchell commented 2 years ago

@jho44 This doesn't look correct, I see in the tests we are making calls using Inline 200. This is a generic response type that basically means we have a problem in our generation. Were you able to successfully do everything in Campaigns with this?

jho44 commented 2 years ago

@jho44 This doesn't look correct, I see in the tests we are making calls using Inline 200. This is a generic response type that basically means we have a problem in our generation. Were you able to successfully do everything in Campaigns with this?

I was able to successfully do everything in Campaigns with this, but I've since fixed it with this Generator PR.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 3141362779

146 of 147 (99.32%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 99.731%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/campaigns-api.ts	142	143	99.3%
<!--	Total:	146	147	99.32%	-->

Totals
Change from base Build 3137516625:	1.6%
Covered Lines:	1984
Relevant Lines:	1987