search

lobaro / FreeRTOS-rust

Rust crate for FreeRTOS
MIT License
326 stars 55 forks source link

Removes FreeRTOS 9.0.0 and adds submodule to official FreeRTOS-Kernel… #33

Closed apullin closed 1 year ago

apullin commented 1 year ago

It looks like there is an edit to a critical function, here:

https://github.com/lobaro/FreeRTOS-rust/blob/master/freertos-rust-examples/FreeRTOS/Source/tasks.c#L3041

While bringing this up on a Cortex M4, I was getting hardfaults in the PendSVHandler after vTaskSwitchContext was called.

This commit changes back to the base FreeRTOS source without the above edit. The source is removed from this repo, and is changed to a submodule.

schteve commented 1 year ago

Looks good to me. I see you set the submodule to point to the recent V10.5.0 which is helpful so we are working with a release and not a random trunk commit.

Since this is only used for examples could you please add a line to the examples readme to mention that the submodule needs to be pulled in order to use the examples? People less familiar with git are likely to miss that the submodule exists and needs to be initialized separately.

apullin commented 1 year ago

Updated with "Checkout" section added to freertos-rust-examples/README.md

schteve commented 1 year ago

Thanks!