search

lobaro / FreeRTOS-rust

Rust crate for FreeRTOS
MIT License
354 stars 56 forks source link

Fix port base for non-linux targets #41

Closed schteve closed 1 year ago

schteve commented 1 year ago

Previous changes in #36 broke the non-Linux examples since the port base path by default was not set correctly. This PR changes the mechanism to use the user-supplied value if available, otherwise fall back on the portable directory inside the FreeRTOS kernel root.

I confirmed that these examples work for me (with adding #define configCPU_CLOCK_HZ to avoid #35). The other have previously-existing build failures, at least on my machine.

@johnathancn please double check that this change still works for your use case.

We've had a bunch of accidental build breakages in the examples recently (understandably so, since users often don't have more than one platform available to test with) so I'm going to make it a priority to get a CI script running for PR's.

johnathancn commented 1 year ago

Sorry I broke this! My mistake for only building my own use case.

Looks good to me, and still working for my use case.

schteve commented 1 year ago

Thanks! And no worries, I didn't build the other stuff either!