lobe / lobe-python

Python toolset for working with Lobe models
MIT License
185 stars 38 forks source link

Python 3.8 support? #20

Closed Pikamander2 closed 3 years ago

Pikamander2 commented 3 years ago

Is there an ETA for when Python 3.8 will be supported? Tensorflow supports Python 3.8 now, so it would be nice to be able to use it.

mbeissinger commented 3 years ago

3.8 should work fine, are you seeing an error?

Pikamander2 commented 3 years ago

Oh cool. I hadn't actually tried it with 3.8 because the readme said to use 3.7. I'll make a pull request for that.

averypfeiffer commented 3 years ago

Can confirm. I've been using it with python 3.8 for a few weeks now. No problem.

Pikamander2 commented 3 years ago

I ran into one error on Windows ('python3' is not recognized as an internal or external command, operable program or batch file.) but otherwise it seems to work fine with Python 3.8.

Here's a pull request to update the docs.

mbeissinger commented 3 years ago

@Pikamander2 Yep I would highly recommend using a virtual environment (python -m venv .venv) so that anything pip3 just becomes pip -- you have to create the virtual environment with the right python being called, so on windows you can do something like: C:\Python38\python.exe -m venv .venv and now when you activate the environment with .venv\Scripts\activate every command related to python (so python and pip) will reference that local environment. More info here: https://docs.python.org/3/tutorial/venv.html

mbeissinger commented 3 years ago

I'll actually add a bit to the readme about the details for virtual environment and that it should support python 3.6-3.8, so will abandon #21 for now

mikematas commented 3 years ago

Finally closed!

On Jul 14, 2021, at 10:56 AM, Markus Beissinger @.***> wrote:

 Closed #20.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mbeissinger commented 3 years ago

@mikematas lol yeah forgot it was still open, no code changes needed XD