lobehub / sd-webui-lobe-theme

๐Ÿ…ฐ๏ธ Lobe theme - The modern theme for stable diffusion webui, exquisite interface design, highly customizable UI, and efficiency boosting features.
https://github.com/AUTOMATIC1111/stable-diffusion-webui
GNU Affero General Public License v3.0
2.33k stars 217 forks source link

[Bug] Folder empty message when incompatible with current Base Model of checkpoint #420

Closed BlafKing closed 10 months ago

BlafKing commented 10 months ago

๐Ÿ’ป ็ณป็ปŸ็Žฏๅขƒ | Operating System

Windows

๐ŸŒ ๆต่งˆๅ™จ | Browser

Chrome

๐Ÿ“ฆ SD Wbui ็‰ˆๆœฌๆˆ–ๆไบค | Version or Commit

https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/5ef669de080814067961f28357256e8fe27544f4

๐Ÿ“ฆ Lobe Theme ็‰ˆๆœฌๆˆ–ๆไบค | Version or Commit

https://github.com/lobehub/sd-webui-lobe-theme/commit/22162d97313a751a6a24aaadd2e6bbcf069459ea

๐Ÿ› ้—ฎ้ข˜ๆ่ฟฐ | Bug Description

When SDXL 1.0 is selected, it doesn't list any models incompatible with SDXL 1.0 So my Textual Inversions for example, do not get listed when a SDXL 1.0 checkpoint is being used.

The current description is quite confusing, since it states that nothing is in the folder, instead of explaining to the user that no compatible models for SDXL 1.0 are found.

I think it would be a lot clearer if the info displayed correctly states that the folder isn't empty, but nothing shows up because nothing is compatible with SDXL 1.0, for me this was really confusing:

SDXL 1.0 Base selected: 2023-09-19 04_48_41

๐Ÿšฆ ๆœŸๆœ›็ป“ๆžœ | Expected Behavior

I'm not exactly sure what the best solution would be, Maybe a check could be done to see if the folders contain any models and change the message according to the presence of models in the folder?

For example if models are found but Automatic1111 has no available models to select a message like this could be shown: image

Otherwise maybe the easiest solution is to change the message all together to something more general like: image

Anything that would indicate to the user that the current Base Model of the Checkpoint is causing the model selection window to be empty, not because of an empty folder.

๐Ÿ“ท ๅค็Žฐๆญฅ้ชค | Recurrence Steps

  1. Select a checkpoint with base model SDXL 1.0
  2. Have no compatible models with SDXL 1.0 in a directory
  3. Folder empty message pops up while folder isn't empty

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

OS: Windows 10 22H2 Python: 3.10.6 Browser: Brave v1.58.127

canisminor1990 commented 10 months ago

These empty messages are provided by default by the sd webui, you can try providing feedback to the webui repository issues.

BlafKing commented 10 months ago

Thanks for letting me know! I'll provide the suggestion there instead ๐Ÿ‘๐Ÿป