lobid / lodmill

This repo is replaced by i.a. https://github.com/hbz/lobid-resources/
19 stars 8 forks source link

Two preferred names for one event #742

Closed acka47 closed 8 years ago

acka47 commented 8 years ago

See http://lobid.org/resource/HT018771475/about where you can find:

{
    "@id" : "http://d-nb.info/gnd/1074109953",
    "preferredName" : [ "7. Schloss Bensberg Classics, 2015, Bergisch Gladbach", "7., 2015, Bergisch Gladbach" ],
    "preferredNameForThePerson" : "7. Schloss Bensberg Classics, 2015, Bergisch Gladbach"
  }

As a result, NWBib looks broken, see http://lobid.org/nwbib/HT018771475.

This probably was introduced with #740.

dr0i commented 8 years ago

A data sample already existing within our unit test data is http://lobid.org/resource/HT014319164.

acka47 commented 8 years ago

Yes, both in http://lobid.org/nwbib/HT018771475 and http://lobid.org/resource/HT014319164 a GND resource is both creator and subject.

acka47 commented 8 years ago

I propose to leave out the birth date in preferedName for GND resources refered to twice in a record.

dr0i commented 8 years ago

See hbz/lobid#244 where I said to only remove the birth date from creator/contributor , NOT subjects. With the upcoming commit this will be changed so that also gnd subject will not have a birth date.

dr0i commented 8 years ago

It should be easy when 9?? (aka subject-chains) could be treated like 1?? (aka persons), but they couldn't because using person we disconfigured the date (subfield d), while this field is desired when dealing not with persons (like here 2015, the year of the event).

dr0i commented 8 years ago

Deployed test set to staging. Please @acka47 have a look and ping if this is fine to deploy the whole data to staging.

dr0i commented 8 years ago

Deployed to staging.

acka47 commented 8 years ago

+1

dr0i commented 8 years ago

Deployed to production, closing.