lobid / lodmill

This repo is replaced by i.a. https://github.com/hbz/lobid-resources/
19 stars 8 forks source link

Two preferredNames for one corporate body #768

Closed acka47 closed 8 years ago

acka47 commented 8 years ago

Reported by NWBib stakeholder I.N. on 2015-12-02. Example http://lobid.org/resource/HT016604323/about.

JSON (snippet):

{
  "@graph" : [ {
    "@id" : "http://d-nb.info/gnd/16090142-X",
    "preferredName" : [ "PsychiatrieVerbund Westfalen. Beschwerdekommission", "PsychiatrieVerbund Westfalen" ],
    "preferredNameForTheCorporateBody" : [ "PsychiatrieVerbund Westfalen. Beschwerdekommission", "PsychiatrieVerbund Westfalen" ]
  } ]
}

There should only be one preferredName not an array of two or more. (There are obvious similarities to #761. I don't know whether the cause of the two problems is similar, though.)

dr0i commented 8 years ago

I changed it to be just one entry. I also would suggest to use a commata as delimiter, like "PsychiatrieVerbund Westfalen, Beschwerdekommission". It strikes me odd if I am seeing sth like "Niedersachen. Süd". What do you think?

dr0i commented 8 years ago

Deployed to minimal staging, see http://gaia.hbz-nrw.de:9200/resources/resource/HT016604323.

acka47 commented 8 years ago

+1

I also would suggest to use a commata as delimiter, like "PsychiatrieVerbund Westfalen, Beschwerdekommission". It strikes me odd if I am seeing sth like "Niedersachen. Süd". What do you think?

lLet's keep the periods for now as customers haven't requested this change yet.

dr0i commented 8 years ago

Deployed with fulldump, closing.

dr0i commented 8 years ago

Data exists in index 2.0 at gaia. Now you can lookup that index to use the labels in the frontend.

fsteeg commented 8 years ago

Deployed to staging: http://test.lobid.org/nwbib/HT016604323

acka47 commented 8 years ago

Deployed to staging: http://test.lobid.org/nwbib/HT016604323

+1

acka47 commented 8 years ago

(We are doing ticket recycling using transformation tickets for deployment in NWBib, don't we? I don't mind and as long as the environment benefits...)

fsteeg commented 8 years ago

Reported by NWBib stakeholder [...]

I'd argue this was actually an NWBib issue in the first place :-)