lobid / lodmill

This repo is replaced by i.a. https://github.com/hbz/lobid-resources/
19 stars 8 forks source link

Missing subfield `b` for corporate bodies #770

Closed acka47 closed 8 years ago

acka47 commented 8 years ago

From https://github.com/lobid/lodmill/issues/766#issuecomment-165767182.

Example HT017150239 (snippet):

<datafield tag="902" ind1="-" ind2="1">
<subfield code="k">Westfalen-Lippe</subfield>
<subfield code="b">Amt für Denkmalpflege in Westfalen</subfield>
<subfield code="b">Fachbereich Praktische Denkmalpflege und Baukultur</subfield>
<subfield code="9">(DE-588)7856688-5</subfield>
</datafield>

Current JSON:

{
    "@id" : "http://d-nb.info/gnd/7856688-5",
    "preferredName" : "Westfalen-Lippe",
    "preferredNameForTheCorporateBody" : "Westfalen-Lippe"
  }
dr0i commented 8 years ago

The problem is the iteration of subfield b. Seems to be valid in MARC21 (see http://www.loc.gov/marc/bibliographic/bd110.html ) and so should be for MAB2, too.

dr0i commented 8 years ago

Deployed to small test set into inde 2.0, see e.g. http://gaia.hbz-nrw.de:9200/resources-staging/resource/HT017150239 .

acka47 commented 8 years ago

I see this is already merged. Nonetheless, here is a +1 from me.

dr0i commented 8 years ago

Sigh , yes, I first merged branches in wrong order resulting in a mess. Will comment the order next time in issues so that this will hopefully not occur again.

dr0i commented 8 years ago

Deployed to full index, closing.

dr0i commented 8 years ago

Data exists in index 2.0 at gaia. Now you can lookup that index to use the labels in the frontend.

fsteeg commented 8 years ago

Already deployed as part of general switch to new data for presentation, see:

http://nwbib.de/HT017150239

acka47 commented 8 years ago

+1. Closing.