Commands bug fix - Githubissues

lobis / hvps

A Python package for controlling high voltage power supplies (HVPS) over serial port. Supports CAEN and iseg power supplies.

https://github.com/lobis/hvps

BSD 3-Clause "New" or "Revised" License

8 stars 2 forks source link

Commands bug fix #65

Open AlvaroEzq opened 1 month ago

AlvaroEzq commented 1 month ago

Fixing a couple of caen devices commands that didn't work.

channel.stat (commit 4bea0b4)
module.board_alarm_status (commit 0fb875d) The problem on both relies on the usage of the check_command_output_and_convert function, where the method argument is not the correct one. This PR fixes both commands with ad-hoc commits. It would be better to have a consistent usage of the check_command_output_and_convert function with the commands mapping, but for now this works...

lobis commented 1 week ago

Hi @AlvaroEzq , let's try to merge this. Is this PR complete or are there more needed changes? I think we would need to test these changes against real hardware to see if they work. I think we should merge this as soon as this is done (maybe it's done already).

AlvaroEzq commented 1 week ago

Hi @AlvaroEzq , let's try to merge this. Is this PR complete or are there more needed changes? I think we would need to test these changes against real hardware to see if they work. I think we should merge this as soon as this is done (maybe it's done already).

I have been using this branch for a long time now with real hardware and it works fine. Maybe it would be better to have a consistent usage of the check_command_output_and_convert function with the commands mapping instead of these ad-hoc fixes but it works with no problems.