search

lobstahbots / scorpion

Overclocked's 2015 FRC Robot ("Scorpion") Code
MIT License
0 stars 0 forks source link

Replace Vector2D with a standard vector library #2

Closed michaelsilver closed 8 years ago

michaelsilver commented 9 years ago

I'm opening this issue so we can lay out and discuss the possibilities going this rout. If we decide to replace Vector2D, testing Vector2D as in #1 is a moot point.

@Owen-Gillespie, if you know of specific options as you suggested in your reply to #1, go ahead and lay them out with links and anything you know/heard about the different libraries as descriptors. We can get a lot of the discussing done this way online.

michaelsilver commented 9 years ago

To clarify, the goal here is to discuss our options, decide what is best (without ruling out the possibility of just staying with Vector2D), and then have one of us create a Pull Request (PR) that implements what we decided on.

michaelsilver commented 8 years ago

Would it be okay if I close this issue? Sort of seems like we'll keep using Vector2D and try to set up some unit testing as in #1

PaulTerrasi commented 8 years ago

I believe we need to stick with Vector2D, because we currently depend on it's unique coordinate system (0 degrees corresponding to (0,1) rather than (1,0)). Changing it would require a very substantial effort that I don't think we want to undergo right now.

On Sat, Nov 14, 2015 at 9:24 PM, Michael Silver notifications@github.com wrote:

Would it be okay if I close this issue? Sort of seems like we'll keep using Vector2D and try to set up some unit testing as in #1 https://github.com/246overclocked/scorpion/issues/1

— Reply to this email directly or view it on GitHub https://github.com/246overclocked/scorpion/issues/2#issuecomment-156771151 .