lobster-dao / overview

Description-FAQ of the process
MIT License
114 stars 24 forks source link

Bug: Fixing "Untextered" trait #43

Open tartakovsky opened 2 years ago

tartakovsky commented 2 years ago

Just to document it here. In the middle of talking to rarity.tools they asked us to fix the Untextered trait before they'll list us. Klibansky is for fixing it too, as he said it wasn't intentional and is a typo. That would require uploading new metadata to ipfs and a tx changing the metadata link in the smart contract. Working on it.

amacar commented 2 years ago

Please fix it, it triggers my OCD. 😅

tartakovsky commented 2 years ago

just to be clear: nobody's removing any traits. There were two traits: Untextured and Untextered. The second one is the typo of the first one. After the change – both of them will be Untextured. The Untextured trait will stay in place.

JonathanlDoe commented 2 years ago

What's the difference between them? Apart from the typo... 😅

zhongfu commented 2 years ago

What's the difference between them? Apart from the typo... 😅

@JonathanlDoe afaict there's no difference, it's just the typo

kkkrackpot commented 2 years ago

What's the difference between them? Apart from the typo... 😅

Difference between what? Some lobs have Gene trait UntextEred instead of UntextUred. It was a typo in the word. The rest is the same as other lobs have. Indeed, two untextered (or 'normal' and untextered) may differ by other traits, images, etc. I doubt there're two identical lobs at all, they're nfts, after all.

tartakovsky commented 2 years ago

Yeah, no difference, Klibansky just did a typo when he entered metadata. Both should be Untextured.

JonathanlDoe commented 2 years ago

So after the typo fix there will be only one Untextured trait, effectively consolidating the two trait groups (untextUred and untextEred) under a single one - Untextured. Right?

tartakovsky commented 2 years ago

Yes.

tartakovsky commented 2 years ago

Just to follow the democratic process and to avoid future issues, here is the vote: https://snapshot.org/#/10b57e6da0.eth/proposal/0xda1aa1b11826bac7246cce93364a74bf7aa42502c0baf8ae060e995bf2b53288

Up for 3 days.

JonathanlDoe commented 2 years ago

Please don't hate me for this, but you do know that in numismatics or philately, the common items with production errors on them are a lot more valuable than the other common common items. Right? 😅

tartakovsky commented 2 years ago

Yeah, that has been voiced already. So far the consensus is that it's more important to remove the mistake, to both look normal, spare people the OCD triggers and proceed with Rarity listing, than to keep the mistake for that purpose. But I see that it's not 100% clear consensus, so there is the vote.

JonathanlDoe commented 2 years ago

Oh. Alright. Mr. Redundant here. Sorray! 🙏

tartakovsky commented 2 years ago

Not redundant, it's important that people say what they want publicly, especially here where it'll stay up longer than in the chat :)

kkkrackpot commented 2 years ago

Fixed. Pls close.