General improvements on the organization and roles

jstoja commented 6 years ago

Hey @pushcx,

I finally got time to work a bit on that. We can discuss about it to thoroughly review it and it's way simpler to integrate it as a whole. You'll see that I split the root playbook in 2 (site.yml and deploy_lobsters.yml). This allows deploys of the rails app to be launched alone and with special parameters in the future. This also start to lay grounds for sister sites (by templating the users, paths, rails db adaptors, ...) There will be more work to come, but this is a first step to avoid a gigantic PR.

The vault file is encrypted with a dumb password that you'll have to change (I'll give it to you on IRC). The way it's structured is also the one recommended by the ansible guides.

Here are the rest of the points:

Simplified os_family by using the ansible_os_family variable.
Reworked playbook/inventory/vars structure following ansible guidelines (used this pattern so variables are well isolated if we add staging).
Added systemd for Lobsters Unicorn process (this combine the unicorn process since it's what makes Lobsters run).
Connected Unicorn with nginx with proxy_pass.
A vault file for secrets is now used to store passwords (check with sysadm to integrate it properly).
Added the creation of the database and user.

If you need anything about this PR, don't hesitate to contact me. This could probably be tested on the staging that @alanpost was talking about if you want to be sure that everything's working as you'd expect.

Cheers!

jstoja commented 6 years ago

This should fix #7 too :)

pushcx commented 6 years ago

This PR is doing so many things I can't evaluate it. Each of your bullet points could've been a PR - some are catching vital missing config like the database setup, but the var changes are worth talking about to decide if they're worth diverging from prgmr for, and I'd rather take a PR to split the root playbook from a sister site that's using it instead of trying to anticipate their needs. I hate to be discouraging, but I have to close this one. Let's catch up in IRC about these.

lobsters / lobsters-ansible

General improvements on the organization and roles #16