search

lobsters / lobsters-ansible

Ansible playbook for lobste.rs
ISC License
79 stars 26 forks source link

Split inventories and group_vars #24

Closed jstoja closed 6 years ago

jstoja commented 6 years ago

This is one of the recommended convention from Ansible's documentation. Setting it up like this will allow adding other inventories (and so environement) in order to add the testing server for the upgrade.

Splitting the variables is also the first step to be able to use them per environement and be able to re-use the variables thorough the playbooks (for example the rails app path will be the same, but not the domain names or things like this).

jstoja commented 6 years ago

This has been partially implemented in #19, but this is a simpler PR if you prefer to review this.

pushcx commented 6 years ago

Thanks, I'll check this out this week. I noted it in the CONTRIBUTING.md for the other repo: I'm now generally only doing Lobsters code on Wednesday and Thursday mornings. I've addressed all the open PRs for the Rails app and am almost done refactoring away the StoryRepository, so it's a good time for me to pay attention to the ansible repo for a while.

jstoja commented 6 years ago

Hey Peter! Great to read :) I should be able to quickly react these next few weeks, so hopefuly we'll make some progress on this repo!

pushcx commented 6 years ago

Looks like a simple way to follow convention, thanks.