search

lobsters / lobsters-ansible

Ansible playbook for lobste.rs
ISC License
79 stars 26 forks source link

Fix kill path in systemd's unit file #30

Closed jstoja closed 6 years ago

jstoja commented 6 years ago

Totally my fault for this one, I should have tested in the Vagrant box (that I will definitely do from now on!). Sorry for the trouble. (Should close #29)

pushcx commented 6 years ago

...huh, I didn't catch this. How is it that this has been working all morning as I've deployed stuff?

jstoja commented 6 years ago

@PeterFaiman Totally agreed on the Unicorn bit in the config to support the reload. I read a bit some exchanges between systemd devs and unicorn devs and it seems that the cohesion of both solutions to have a perfect reload is not yet implemented.

To be honest, I don't have any idea that could explain why the reloads worked for you @pushcx ...

The proposed changed of @PeterFaiman seem great to me, so I'll create another PR (not to pollute this one that solves the linked issue), with his proposed changes.