search

lobsters / lobsters-ansible

Ansible playbook for lobste.rs
ISC License
78 stars 25 forks source link

roles/mockturtle: invite trigger for recently joined users #53

Closed bbuccianti closed 4 years ago

bbuccianti commented 4 years ago

I think this is it!

bbuccianti commented 4 years ago

I've tested locally the module and seems to work fine!

Let me know if you try it and sorry for the awful commits that I send you to review before.

I'm learning a lot, thank you very much for your patience!

alanpost commented 4 years ago

@bbuccianti, I am closing this pull request without merging it. The reason is that the work you've done here was cherry-picked and moved from lobsters-ansible.git in to mockturtle.git:

https://github.com/lobsters/mockturtle/commit/966cb5826c52797c641837550aea97d3e50dbd89

So while I am closing this PR, the work you did has been checked in--it's that while this PR was open we decided to move the code out of lobsters-ansible (PR #61), and in so doing add unit tests verifying this Sopel plugin worked as intended. Those unit tests went in to mockturtle.git at the same time your commit did, as the first PR in that repository:

https://github.com/lobsters/mockturtle/pull/1

Thank you for your help and patience.