search

locaal-ai / obs-cleanstream

CleanStream is an OBS plugin that uses AI to clean live audio streams from unwanted words and utterances
https://obsproject.com/forum/resources/cleanstream-remove-uhs-ums-profanity-in-your-live-stream-or-recording-with-ai.1732/
GNU General Public License v2.0
140 stars 11 forks source link

OBS crashes after adding Cleanstream filter to a source #1

Closed PowerfulDot closed 1 year ago

PowerfulDot commented 1 year ago

OBS crashes after adding the clean stream filter to a source. First crash was after adding the source to a microphone that was added as a Source Clone (from the plugin of that name).

The second crash was when I tried to add it as a filter to a microphone as a normal audio input capture source.

To Reproduce

Steps to reproduce the behavior:

  1. Select source
  2. Select Filters
  3. Add Cleanstream from the add filter menu.
  4. After a couple of seconds, OBS crashes.

Expected behavior: Add the filter and use it normally.

Log and Crash Report

LOG: 2023-06-19 17-09-33.txt

Crashes Crash 2023-06-19 16-36-52.txt Crash 2023-06-19 16-51-41.txt

royshil commented 1 year ago

I think I know what the problem is. Windows has some quirks when it comes to string processing. I'll be around my Windows machine tomorrow to try to debug it. Thanks for the issue!

royshil commented 1 year ago

@PowerfulDot can you please try the version at https://github.com/royshil/obs-cleanstream/actions/runs/5328946242?pr=2 ? for me it works on mac and windows

PowerfulDot commented 1 year ago

Thanks much for your quick work! This version is crashing too. Maybe it's me!

[Crash 2023-06-21 09-34-07.txt](https://github.com/royshil/obs-cleanstream/files/118209 2023-06-21 09-37-40.txt 82/Crash.2023-06-21.09-34-07.txt)

PowerfulDot commented 1 year ago

Apologies, my crash log got weird there. Crash 2023-06-21 09-34-07.txt

royshil commented 1 year ago

I will do more testing and debugging today on my 2 windows PCs. But so far they have been working, so I need to find the actual bug.

One thing to try is to make several attempt at opening OBS and applying the plugin. If you don't get a crash in one attempt and the plugin works - this gives a good clue as to where the problem really is (threading and deadlocks 🤦‍♂️, but possibly buffer overrun and dirty pointers).

PowerfulDot commented 1 year ago

This worked! I had a crash and then the next time I tried I was able to add the filter. I made a short recording and it clearly removed some ums, ahs, and also beeped my swears. Awesome! Attached are the crash report and regular logs from both the crashed session and the working session. Happy to do more testing of any kind if it helps!

Crash 2023-06-22 12-22-55.txt 2023-06-22 12-22-04.txt 2023-06-22 12-23-02.txt

royshil commented 1 year ago

@PowerfulDot can you please try https://github.com/royshil/obs-cleanstream/releases/tag/v0.0.1b ? i think i've found most major bugs

PowerfulDot commented 1 year ago

Alright it loads up without crashing, multiple tries now! Thanks so much.