download_thread and download_worker are automatically being deleted when they were finished, leaving dangling pointers; accessing those pointers from the destructor of ModelDownloader causes OBS to crash for me on shutdown (or alternatively hang on shutdown with no visible windows)
Additionally, ModelDownloader was only being deleted at shutdown; with this it's instead deleted after it's closed
download_threadanddownload_workerare automatically being deleted when they were finished, leaving dangling pointers; accessing those pointers from the destructor ofModelDownloadercauses OBS to crash for me on shutdown (or alternatively hang on shutdown with no visible windows)Additionally,
ModelDownloaderwas only being deleted at shutdown; with this it's instead deleted after it's closed