Fix zipkin 9.1.0 - Githubissues

local-ch / lhc

🚀 Advanced HTTP Client for Ruby. Fueled with interceptors.

GNU General Public License v3.0

43 stars 1 forks source link

Fix zipkin 9.1.0 #123

Closed skaestle closed 6 years ago

skaestle commented 6 years ago

after letting the implementation run in the real-world. @golonzovsky and I have found an issue with spans that were not being added to parent.

turns out my implementation created unecessary spans that lead to that behavior.

this PR ensures:

B3 headers are always sent even if sampled? is false
however a span is only created if sampled? is true