Closed 10xSebastian closed 6 years ago
PATCH
I really don't know for how long this is in there, checked https://github.com/typhoeus/typhoeus and https://github.com/typhoeus/ethon and it seems typhoeus Responses returned seconds for time ever since.
time
That bug made consuming apps and interceptors (like the logging interceptor) retrieve milliseconds, even though they thought it's seconds (according to the documentation):
> response = LHC.get('http://www.google.com/') > response.time => 99.75 > response.time_ms => 0.09975
It's patched, time returns seconds properly, and time_ms returns milliseconds 🙈
time_ms
PATCH
I really don't know for how long this is in there, checked https://github.com/typhoeus/typhoeus and https://github.com/typhoeus/ethon and it seems typhoeus Responses returned seconds for
time
ever since.That bug made consuming apps and interceptors (like the logging interceptor) retrieve milliseconds, even though they thought it's seconds (according to the documentation):
Now
It's patched,
time
returns seconds properly, andtime_ms
returns milliseconds 🙈