search

local-ch / lhc

🚀 Advanced HTTP Client for Ruby. Fueled with interceptors.
GNU General Public License v3.0
43 stars 1 forks source link

Avoid zipkin warnings in test and dev #154

Closed 10xSebastian closed 5 years ago

10xSebastian commented 5 years ago

We get the following warnings a lot (unnecessarily)

[WARNING] Zipkin interceptor is enabled but dependencies are not found. See: https://github.com/local-ch/lhc#zipkin

This PR decouples tracing? (if tracing is happening) from dependencies? (which clearly just checks for dependencies.

So in your tests it would still complain if Zipkin has wrong dependencies (which might make your app crash when deployed), but it's not flooding you with warnings any longer, just because there is no current trace!