local-ch / lhc

🚀 Advanced HTTP Client for Ruby. Fueled with interceptors.
GNU General Public License v3.0
43 stars 1 forks source link

Improve prometheus monitoring #168

Closed scan closed 4 years ago

scan commented 4 years ago

Up to now, the timings from the prometheus monitoring were not very useful. They were using a key that is not following conventions and also using milliseconds with histogram buckets that only go up to 10. Meaning every request that takes longer than 10ms was not even monitored any more.

This follows the convention for histograms more closely and also adds the host label, so we can determine which requests are actually slow instead of guessing.

Also we now use a single key, lhc_requests and lhc_request_seconds, and differentiate the event using a label. This allows us to create a board that shows all of the LHC requests over several apps.