local-motion / product

Apache License 2.0
2 stars 1 forks source link

playground name validations #400

Closed dimitriirtimid closed 5 years ago

dimitriirtimid commented 5 years ago

The playground name must match the following criteria:

image

dimitriirtimid commented 5 years ago

@maxvisser Can you please validate these specs?

maxvisser commented 5 years ago

Yes looks great. Also thought a bit more about a name being unique; as it is currently uncertain if there will be a copy of the application for new use case; I can see workspaces having not unique names in some other use cases. As we currently can't really grasp the full scope of these other use cases and if this is really needed; I think we should leave it as it is now (unique names).

dimitriirtimid commented 5 years ago

Agreed. In the end we may end up with prefixing the name with the 'campaign' name (like smokefree playgrounds) or having dedicated urls / domains per campaign (like we have currently). The uniqueness requirement is mainly in order to not confuse the users. The system has no problem with non-unique names, except for the url encoding. But we can always adapt this at a later stage.

Note that I added one more constraint: There can be no consecutive spaces in the playground name.

Closing this issue now as the logic has already been completed and merged in