Check 'GVAS' header, require pub doc strings

localcc / gvas

GVAS file format parsing library for rust

MIT License

19 stars 2 forks source link

Closed scottanderson closed 1 year ago

scottanderson commented 1 year ago

Check GVAS header for 'GVAS' bytes, throw new error type for unexpected value
Warn on missing doc strings (will cause clippy check to fail, making docstrings required for submissions)

konsti219 commented 1 year ago

Making PR after PR with the same name will get confusing real fast. Recommended git practice is to make one PR per change.

localcc commented 1 year ago

Yeah, a bunch of smaller PRs with better titles would be appreciated in the future.

scottanderson commented 1 year ago

Sure. I have been organizing individual features in to commits, but it is no problem to submit one PR for each feature going forward.