localdevices / pyorc

Surface velocity, object tracking, and river flow measurements in an open-source API
GNU Affero General Public License v3.0
129 stars 31 forks source link

bug with windows machines fixed, where local coordinate system coordinates were in some cases truncated when 64-bit floats were subtracted from 32-bit floats. This is a behaviour in numpy #145 #146

Closed hcwinsemius closed 8 months ago

hcwinsemius commented 8 months ago

This bug probably only appeared on windows machines.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (07f9788) 81.21% compared to head (25c0ece) 81.22%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #146 +/- ## ======================================= Coverage 81.21% 81.22% ======================================= Files 20 20 Lines 2795 2801 +6 ======================================= + Hits 2270 2275 +5 - Misses 525 526 +1 ``` | [Files](https://app.codecov.io/gh/localdevices/pyorc/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=localdevices) | Coverage Δ | | |---|---|---| | [pyorc/cli/cli\_utils.py](https://app.codecov.io/gh/localdevices/pyorc/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=localdevices#diff-cHlvcmMvY2xpL2NsaV91dGlscy5weQ==) | `66.86% <0.00%> (ø)` | | | [pyorc/cv.py](https://app.codecov.io/gh/localdevices/pyorc/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=localdevices#diff-cHlvcmMvY3YucHk=) | `89.81% <85.71%> (-0.13%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.