search

localgovdrupal / github_workflow_manager

Manage GitHub workflow files across LocalGov Drupal repos.
GNU General Public License v2.0
0 stars 0 forks source link

PHP 8.2/8.3 support #8

Open millnut opened 1 year ago

millnut commented 1 year ago

@finnlewis @stephen-cox it would be good to add PHP 8.2 into the workflow as Drupal 10.x supports PHP 8.1 and 8.2. It would also be helpful as it would flag any issues when running under PHP 8.2.

The only relevant ticket I could find on this is https://github.com/localgovdrupal/localgov/issues/523.

It also looks like Drupal are planning to support PHP 8.3 in Drupal 10.2 (https://www.drupal.org/docs/getting-started/system-requirements/php-requirements#versions) with the first beta the week of November 13, 2023 so it might be an idea to add PHP 8.3 once the beta for Drupal 10.2 is released and then create issues for each area (should there be any) to fix ready for the release of Drupal 10.2

finnlewis commented 1 year ago

Thanks @millnut , good call.

I think @stephen-cox might have said that the workflows across all the projects have evolved and diverged a bit in recent months, so it might be harder to roll out a change across all repositories with this github_workflow_manager.

Either way, a good place to start could be the localgov_project, by adding php 8.2 to the workflow there, https://github.com/localgovdrupal/localgov_project/blob/3.x/.github/workflows/test.yml

This would at least start testing across the whole distribution.

millnut commented 1 year ago

Thanks @finnlewis I wasn't sure if it was centrally managed or by each repo. I'll create a PR on the localgov_project repo later today for PHP 8.2.