Open willguv opened 1 year ago
Note; this is configuration in the tab group. Setting up vertical tabs, allows you to set the breakpoint.
Note: this would probably just be for new installs.
Tasks:
@stephen-cox please review Simon's PRs - thanks
@stephen-cox have you reviewed/ finished these PRs? Thanks
Hi @willguv - these are all merged apart from https://github.com/localgovdrupal/localgov_services/pull/235, which has test failures that we haven't got to the bottom of.
Yes
On Tue, Feb 13, 2024, 2:34 PM Stephen Cox @.***> wrote:
Hi @willguv https://github.com/willguv - these are all merged apart from localgovdrupal/localgov_services#235 https://github.com/localgovdrupal/localgov_services/pull/235, which has test failures that we haven't got to the bottom of.
— Reply to this email directly, view it on GitHub https://github.com/localgovdrupal/localgov/issues/538#issuecomment-1941650119, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTROUWBEU3Q5NMXU3CMF23YTN2ZFAVCNFSM6AAAAAAXLMNAY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRGY2TAMJRHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I've merged the latest 2.x into the PR at #235
All tests are passing now, and the PR is working. I'm going to mark it as approved.
=== Thanks to Big Blue Door for sponsoring my time to work on this.
Following on from Andy's comment
Let's consider the impact of this change