Open willguv opened 3 months ago
This needed a combination of changes in the following PRs:
The resulting order of the Content page tabs after the above PRs make it into the main branch are:
Thanks @MariosORION !
Thanks for this @MariosORION ! Here's how I tested:
drush cr
)Crikey, quite a few pull requests to get through to re-arrange the tabs! I guess that makes sense.
Although, thinking about it now, could all this code be in one module? localgov_core for example? Oh no... I see now, lots of them are the default weight from config: https://github.com/localgovdrupal/localgov_directories/pull/379/files
Sorry! Totally makes sense!
Thanks @MariosORION and @willguv :smiley_cat:
This is brilliant, thanks Finn for testing and writing up these docs. I'll be able to take modules and branches for a spin, freeing up dev time. Will encourage others to get involved too.
Also thanks very much @MariosORION for picking this up at short notice.
Great work all round!
This is great, thanks both! Indeed @finnlewis , I wanted to keep the changes as "local" as possible hence the separate PRs. I was thinking about a testing workflow for this kind of change (e.g. referencing the actual branches in composer.json for local testing) - it looks like the Gitpod approach works really well - nice one! 👍👍
@MariosORION - quick question ( came up while reviewing and merging) - do the local tasks weights get exported as config, and so is it something that a specific site can override with config import?
@finnlewis short answer is yes. Long answer: Local tasks are made to primarily be static. Defaults are defined in example.links.task.yml files and hook_menu_local_tasks_alter can be used to alter these. The PRs here use a combination of the two, depending on the relative weight required for each item and how each item's weight is already defined (or altered) in the corresponding module. A specific site could override all of these using the same hook (also assuming that the weight of the module of the specific site where the hook implementation is added is greater than the weights of the modules utilising the same hook in these PRs).
Just installed this - looks great, thanks @MariosORION!
Great to hear, @willguv !
This is the current order
Media and Alert banners are used often but are too far over to the right
I think the order should be:
The reasoning for this is as follows: