localgovdrupal / localgov

Installation profile for the LocalGov Drupal distribution.
GNU General Public License v2.0
83 stars 19 forks source link

adds content_access_by_path module #745

Open markconroy opened 4 months ago

markconroy commented 4 months ago

Creating PR for the profile instead of LocalGov Drupal Core, see https://github.com/localgovdrupal/localgov_core/pull/215


Thanks to Big Blue Door for sponsoring my time to work on this.

finnlewis commented 4 months ago

Briefly discussing in Merge Tuesdays:

  1. would like to run this through our policy to check for bringing this into the localgov profile. Do enough councils want this by default etc.
  2. also I wanted to test and check on any potential security assumptions: if paths change for other reasons, might this give access to manage content by accident?

Tasks:

stephen-cox commented 4 months ago

Will has tried to ask content people about this, but has not had any responses.

andybroomfield commented 2 months ago

What do I need to do to review?

andybroomfield commented 2 months ago

Looking at the issue, this is so it's avalible to people as part of the profile, but not installed by default. So this PR passes in terms of adding the module, if that is aggreed can approve on that basis.

finnlewis commented 2 months ago

Hi @willguv

Could we review the policy https://docs.localgovdrupal.org/governance/new-features-policy.html

and check in on point 1?

Also @andybroomfield want to check in on the security aspects. If paths change, does this change the access control?