search

localgovdrupal / localgov

Installation profile for the LocalGov Drupal distribution.
GNU General Public License v2.0
83 stars 19 forks source link

Add Drupal 11 support to profile #766

Open stephen-cox opened 2 months ago

stephen-cox commented 2 months ago

Report from the Upgrade Status module

================================================================================
LocalGov Drupal, --
Scanned on Fri 06/09/2024 2:39pm

FILE:
web/profiles/contrib/localgov/modules/localgov_content_lock/tests/src/Functional
/ContentLockTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 37   Dynamic call to static method                               
                    PHPUnit\Framework\Assert::assertTrue().                     
--------------------------------------------------------------------------------

FILE:
web/profiles/contrib/localgov/modules/localgov_login_redirect/src/Form/LoginRedi
rectSettingsForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 91   Construct empty() is not allowed. Use more strict           
                    comparison.                                                 
--------------------------------------------------------------------------------

FILE: web/profiles/contrib/localgov/src/Plugin/Block/HomeWelcomeBlock.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 33   Construct empty() is not allowed. Use more strict           
                    comparison.                                                 
--------------------------------------------------------------------------------

FILE: web/profiles/contrib/localgov/tests/src/Functional/LocalGovProfileTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 30   Dynamic call to static method                               
                    PHPUnit\Framework\Assert::assertTrue().                     
--------------------------------------------------------------------------------
Check manually 33   Dynamic call to static method                               
                    PHPUnit\Framework\Assert::fail().                           
--------------------------------------------------------------------------------
Check manually 37   Dynamic call to static method                               
                    PHPUnit\Framework\Assert::assertTrue().                     
--------------------------------------------------------------------------------
Check manually 41   Dynamic call to static method                               
                    PHPUnit\Framework\Assert::assertTrue().                     
--------------------------------------------------------------------------------

FILE: web/profiles/contrib/localgov/localgov.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/profiles/contrib/localgov/modules/localgov_content_lock/localgov_content_loc
k.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/profiles/contrib/localgov/modules/localgov_login_redirect/localgov_login_red
irect.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: web/profiles/contrib/localgov/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 1    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://www.drupal.org/docs/develop/using-composer/add-a-com
                    poserjson-file#core-compatibility.                          
--------------------------------------------------------------------------------
millnut commented 2 months ago

I think most of this is fixed apart from the core requirement change.

Dynamic call to static method PHPUnit\Framework\Assert::assertTrue() can be ignored based on the comms here https://www.drupal.org/project/drupal/issues/3029358 as I don't think core plans on changing this from $this-> to static:: anytime soon